You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/01 13:05:23 UTC
[GitHub] [flink] matriv commented on a change in pull request #17624: [FLINK-24714][table-api-java] Validate partition keys for ResolvedCatalogTable
matriv commented on a change in pull request #17624:
URL: https://github.com/apache/flink/pull/17624#discussion_r740191985
##########
File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/CatalogBaseTableResolutionTest.java
##########
@@ -170,6 +170,28 @@ public void testPropertyDeserializationError() {
}
}
+ @Test
+ public void testInvalidPartitionKeys() {
+ final CatalogTable catalogTable =
+ CatalogTable.of(
+ TABLE_SCHEMA,
+ null,
+ Arrays.asList("region", "countyINVALID"),
+ Collections.emptyMap());
+
+ try {
+ resolveCatalogBaseTable(ResolvedCatalogTable.class, catalogTable);
+ fail();
Review comment:
nit: Maybe a short message in case this is reached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org