[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #885: feat: added disableWAL option

[GitBox <gi...@apache.org>]

git-hulk commented on code in PR #885:
URL: https://github.com/apache/incubator-kvrocks/pull/885#discussion_r974342286


##########
src/config.cc:
##########
@@ -174,6 +174,7 @@ Config::Config() {
       {"rocksdb.delayed_write_rate", false, new Int64Field(&RocksDB.delayed_write_rate, 0, 0, INT64_MAX)},
       {"rocksdb.wal_ttl_seconds", true, new IntField(&RocksDB.WAL_ttl_seconds, 3*3600, 0, INT_MAX)},
       {"rocksdb.wal_size_limit_mb", true, new IntField(&RocksDB.WAL_size_limit_MB, 16384, 0, INT_MAX)},
+      {"rocksdb.disableWAL", true, new YesNoField(&RocksDB.disableWAL, false)},

Review Comment:
   I also found this point, I think it should be inconsistent in RocksDB NOT the intent. `disable_wal` even `disable_WAL` is better than `disableWAL`, what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org