You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jkeshavarzi <gi...@git.apache.org> on 2014/07/28 00:20:20 UTC
[GitHub] cordova-blackberry pull request: CB-6725 - Adding support for cust...
GitHub user jkeshavarzi opened a pull request:
https://github.com/apache/cordova-blackberry/pull/171
CB-6725 - Adding support for custom bar name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkeshavarzi/cordova-blackberry master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-blackberry/pull/171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #171
----
commit f73266a745281cc555f96ab3d4d9b73840f9d992
Author: James Keshavarzi <jk...@blackberry.com>
Date: 2014-07-27T19:26:10Z
CB-6725 - Adding support for custom bar name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: CB-6725 - Adding support for cust...
Posted by jkeshavarzi <gi...@git.apache.org>.
Github user jkeshavarzi closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: CB-6725 - Adding support for cust...
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/171#issuecomment-50357274
@jkeshavarzi thanks for the pull request, but please close it for now
As we discussed with @jsoref, users of other platforms have run into trouble with custom names for build output. There is a desire to move to a static name similar to BB and possibly re-name the file as a post-build step.
We will see how this unfolds and potentially use your logic to implement the cross platform solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---