You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/31 03:31:03 UTC

[GitHub] [dolphinscheduler] rickchengx commented on a diff in pull request #12118: [Fix-12109] Fix the errors when starting 2 times with dolphinscheduler-daemon.sh

rickchengx commented on code in PR #12118:
URL: https://github.com/apache/dolphinscheduler/pull/12118#discussion_r1009002835


##########
script/dolphinscheduler-daemon.sh:
##########
@@ -81,8 +79,26 @@ else
   exit 1
 fi
 
+state=""
+function get_server_running_status() {
+  state="STOP"
+  if [ -f $pid ]; then
+    TARGET_PID=`cat $pid`
+    server_running_count=`ps -p $TARGET_PID --no-headers | wc -l`

Review Comment:
   > It seems like `--no-headers` can not be running in `MacOS`. It's better to use a compatible way.
   
   @SbloodyS Thanks a lot for pointing out that, I have removed `--ho-headers`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org