[GitHub] gianm commented on a change in pull request #5998: Add support to filter on datasource for active tasks

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #5998: Add support to filter on datasource for active tasks
URL: https://github.com/apache/incubator-druid/pull/5998#discussion_r203495466
 
 

 ##########
 File path: indexing-service/src/main/java/io/druid/indexing/overlord/http/OverlordResource.java
 ##########
 @@ -632,14 +632,14 @@ public Response getTasks(
     List<TaskInfo<Task>> allActiveTaskInfo = Lists.newArrayList();
     final List<AnyTask> allActiveTasks = Lists.newArrayList();
     if (state == null || !"complete".equals(StringUtils.toLowerCase(state))) {
-      allActiveTaskInfo = taskStorageQueryAdapter.getActiveTaskInfo();
+      allActiveTaskInfo = taskStorageQueryAdapter.getActiveTaskInfo(dataSource);
       for (final TaskInfo<Task> task : allActiveTaskInfo) {
         allActiveTasks.add(
             new AnyTask(
                 task.getId(),
                 task.getTask() == null ? null : task.getTask().getType(),
                 SettableFuture.create(),
-                task.getDataSource(),
+                task.getDataSource(), // ?
 
 Review comment:
   What does the `// ?` comment mean?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org