You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/07/06 21:51:35 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #5031: HDDS-8984. Keep separate Robot XMLs if rebot fails to combine them
adoroszlai opened a new pull request, #5031:
URL: https://github.com/apache/ozone/pull/5031
## What changes were proposed in this pull request?
Test results for `test-root-ca-rotation.sh` failure (see HDDS-8983) are missing, because `rebot` encountered error processing one of the files (hence no combined XML is available), but then the script deleted individual XMLs.
This PR changes the acceptance test lib to only delete separate Robot XMLs if combination (`rebot ...`) is successful. This ensures we have some test output in both cases.
https://issues.apache.org/jira/browse/HDDS-8984
## How was this patch tested?
Not yet, need repro of HA-secure test failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Galsza commented on pull request #5031: HDDS-8984. Keep separate Robot XMLs if rebot fails to combine them
Posted by "Galsza (via GitHub)" <gi...@apache.org>.
Galsza commented on PR #5031:
URL: https://github.com/apache/ozone/pull/5031#issuecomment-1625535341
Thank you Attila, this looks good to me. +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #5031: HDDS-8984. Keep separate Robot XMLs if rebot fails to combine them
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5031:
URL: https://github.com/apache/ozone/pull/5031#issuecomment-1631507626
Thanks @Galsza, @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #5031: HDDS-8984. Keep separate Robot XMLs if rebot fails to combine them
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5031:
URL: https://github.com/apache/ozone/pull/5031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org