[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2151: HDFS-15476 Make AsyncStream executor private

[GitBox <gi...@apache.org>]

GauthamBanasandra commented on a change in pull request #2151:
URL: https://github.com/apache/hadoop/pull/2151#discussion_r456912037



##########
File path: hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/async_stream.h
##########
@@ -41,7 +41,6 @@ typedef boost::asio::const_buffers_1   ConstBuffer;
 class AsyncStream  {
 public:
   using executor_type = boost::asio::system_executor;

Review comment:
       Could you try making this type alias private as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org