You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "gerbermichi (via GitHub)" <gi...@apache.org> on 2026/08/25 12:05:26 UTC
[PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
gerbermichi opened a new pull request, #43515:
URL: https://github.com/apache/superset/pull/43515
### SUMMARY
The ECharts axis option `minInterval` was not configurable from the UI. Without it, ECharts picks tick steps on its own, which produces fractional ticks on integer metrics (0, 0.5, 1, 1.5 …) and, on time axes, tick steps that do not match the granularity the user cares about.
This PR exposes `minInterval` as a "Minimum Interval" control for both the X and the Y axis of the **Bar Chart** and the **Line Chart**.
Details:
- Two new shared controls in `plugin-chart-echarts/src/controls.tsx`: `x_axis_min_interval` and `y_axis_min_interval` (numeric `TextControl`, `renderTrigger: true`, empty by default).
- `Timeseries/transformProps.ts` maps them onto `xAxis.minInterval` / `yAxis.minInterval`. Empty, non-numeric or non-positive values are ignored, so the default behaviour is unchanged and ECharts keeps calculating ticks automatically.
- On the X axis a user-defined value takes precedence over the interval derived from the time grain (the existing `force_max_interval` behaviour is untouched when the control is empty).
- For horizontal bar charts the value follows the existing axis swap, so "X Axis" in the control panel always refers to the axis the user sees as X.
On a time axis the value is expressed in milliseconds; this is stated in the control description.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - the control panel gains one input per axis; chart rendering is unchanged unless a value is entered.
### TESTING INSTRUCTIONS
1. Create a Bar Chart with an integer metric (e.g. `COUNT(*)`) whose values are small, so the Y axis shows fractional ticks.
2. Go to *Customize → Chart Options → Y Axis* and set **Minimum Interval** to `1`. The Y axis now only shows whole numbers, without a requery.
3. Switch *Bar orientation* to Horizontal and confirm the control moves to the matching axis section and still applies to the value axis.
4. Set *Customize → Chart Options → X Axis → Minimum Interval* to `86400000` on a temporal X axis and confirm the labels are at least one day apart.
5. Clear both fields and confirm the axes fall back to the automatic ECharts ticks.
6. Repeat steps 2 and 4 with a Line Chart.
Automated tests: `npm run test -- plugins/plugin-chart-echarts/test` (821 tests). New unit tests cover applying the value to both axes, the swap for horizontal bar charts, ignoring empty/invalid input, and the presence of the controls in both control panels.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-6307131829
Heya @gerbermichi, this one looked done but `babel-extract` was failing, so I pushed a fix.
The new "Minimum Interval" labels and descriptions never made it into `messages.pot`, since `scripts/translations/babel_update.sh` hadn't been re-run after adding the controls. Ran it and committed the regenerated `.pot`/`.po` files.
On the review threads: the two CodeAnt findings are already resolved (one by a later commit, confirmed in my earlier approval too), and I don't think the Bito "inverted assertion" catch holds up either, already said as much when I approved. Should just be CI now. Holler if anything else comes up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5648005934
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43515?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.26%. Comparing base ([`598d5f7`](https://app.codecov.io/gh/apache/superset/commit/598d5f723b02d99ee21ef79935135ddf0904f89a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`50ae8d5`](https://app.codecov.io/gh/apache/superset/commit/50ae8d537b27af872e58d574b863702458c7034a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43515 +/- ##
=======================================
Coverage 76.26% 76.26%
=======================================
Files 2925 2925
Lines 172644 172671 +27
Branches 40076 40089 +13
=======================================
+ Hits 131661 131682 +21
- Misses 38303 38309 +6
Partials 2680 2680
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43515/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.66% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43515?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5927901591
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5410121467
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5647754665
Thanks for this, the minInterval control is a nice addition. Looks like it needs a rebase (conflicts with master right now), and one of the jest shards is failing in CI. The bot comments about the horizontal bar swap look right to me too: minInterval doesn't get swapped between axes like the other values do for horizontal bars, and the new yVisibility test seems to assert the opposite of what the code actually does. Can you take a look at those before we merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5421614577
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | e1d14667c3e641a6d0e083370cfbb327de8f44f4 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a8e8af1fb624e00082b9b08 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43515--superset-docs-preview.netlify.app](https://deploy-preview-43515--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpLCoAgEADQu8w6ySLEukHHGHVEwR8qUUR3z91bvBdKzbF0OAAmUBWTdsOWsM-kHdbeGN6-segT86lTvTCMaaiE_JxmXIGSJNrFKrFuxDmXq9oVl_D9) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43515--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43515:
URL: https://github.com/apache/superset/pull/43515#discussion_r4152019418
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx:
##########
@@ -193,12 +195,14 @@ const config: ControlPanelConfig = {
],
[xAxisLabelRotation],
[xAxisLabelInterval],
+ [xAxisMinInterval],
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `0813c6b`.
Added a visibility predicate to the X-axis minimum-interval control that shows it only when the selected X-axis column is temporal or numeric, and configured it to reset when hidden.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5412717652
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43515:
URL: https://github.com/apache/superset/pull/43515#discussion_r3852799331
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx:
##########
@@ -193,12 +195,14 @@ const config: ControlPanelConfig = {
],
[xAxisLabelRotation],
[xAxisLabelInterval],
+ [xAxisMinInterval],
Review Comment:
**Suggestion:** The X-axis minimum-interval control is added without a visibility predicate, so it is displayed for categorical X axes even though the control description says it only applies to numeric and time axes. Because `transformProps` still maps the entered value to `xAxis.minInterval`, users can save a setting that has no effect on categorical charts. Add visibility based on the selected X-axis column type, consistent with the existing X-axis format controls. [api mismatch]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Categorical Line Chart settings expose an ineffective control.
- ⚠️ Users may believe tick spacing changed when it did not.
- ⚠️ Inapplicable values remain persisted in chart form data.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5b90183ceb9b49549021a56ca9751b57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5b90183ceb9b49549021a56ca9751b57&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx
**Line:** 198:198
**Comment:**
*Api Mismatch: The X-axis minimum-interval control is added without a visibility predicate, so it is displayed for categorical X axes even though the control description says it only applies to numeric and time axes. Because `transformProps` still maps the entered value to `xAxis.minInterval`, users can save a setting that has no effect on categorical charts. Add visibility based on the selected X-axis column type, consistent with the existing X-axis format controls.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43515&comment_hash=6faf537094c614fe46459b822356cbc59f52d5f0d6e4cf691cf716a04a17ca32&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43515&comment_hash=6faf537094c614fe46459b822356cbc59f52d5f0d6e4cf691cf716a04a17ca32&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43515:
URL: https://github.com/apache/superset/pull/43515#discussion_r4140653470
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx:
##########
@@ -193,12 +195,14 @@ const config: ControlPanelConfig = {
],
[xAxisLabelRotation],
[xAxisLabelInterval],
+ [xAxisMinInterval],
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `9d968df`.
The x_axis_min_interval control now uses a visibility predicate that checks whether the selected X-axis column is temporal or numeric, and resets/stashes the control when hidden.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #43515:
URL: https://github.com/apache/superset/pull/43515#discussion_r3854590703
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/Bar/controlPanel.test.ts:
##########
@@ -292,3 +292,31 @@ test('x_axis_time_format should be hidden for numeric columns', () => {
false,
);
});
+
+const xMinIntervalControl: any = getControl('x_axis_min_interval');
+const yMinIntervalControl: any = getControl('y_axis_min_interval');
+
+test('should include the minimum interval controls for both axes', () => {
+ expect(xMinIntervalControl).toBeDefined();
+ expect(yMinIntervalControl).toBeDefined();
+ expect(xMinIntervalControl.config.default).toBeNull();
+ expect(yMinIntervalControl.config.default).toBeNull();
+ expect(xMinIntervalControl.config.renderTrigger).toBe(true);
+ expect(yMinIntervalControl.config.renderTrigger).toBe(true);
+});
+
+test('minimum interval controls follow the bar orientation', () => {
+ const xVisibility = xMinIntervalControl?.config?.visibility;
+ const yVisibility = yMinIntervalControl?.config?.visibility;
+ const vertical = mockBarControls('date', GenericDataType.Temporal);
+ const horizontal = mockBarControls(
+ 'date',
+ GenericDataType.Temporal,
+ OrientationType.Horizontal,
+ );
+
+ expect(xVisibility(vertical)).toBe(true);
+ expect(xVisibility(horizontal)).toBe(false);
+ expect(yVisibility(vertical)).toBe(false);
+ expect(yVisibility(horizontal)).toBe(true);
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inverted test assertion</b></div>
<div id="fix">
The test assertions for `yVisibility` are inverted against the implementation. The implementation in `controlPanel.tsx` line 260-261 uses `isXAxis ? isHorizontal(controls) : isVertical(controls)` which returns true when `isVertical` (orientation is Vertical) and `axis !== 'x'` — meaning the y-axis min interval is shown when `controls.orientation.value === OrientationType.Vertical` (in vertical bar orientation). However, the test expects `yVisibility(vertical) === true` and `yVisibility(horizontal) === false`, which is the opposite. This will cause the test suite to fail on every run.
</div>
</div>
<small><i>Code Review Run #365d2a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5906005975
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43515:
URL: https://github.com/apache/superset/pull/43515#discussion_r4332673026
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx:
##########
@@ -193,12 +195,14 @@ const config: ControlPanelConfig = {
],
[xAxisLabelRotation],
[xAxisLabelInterval],
+ [xAxisMinInterval],
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `88e06ee`.
Added a visibility predicate to the X-axis minimum-interval control that shows it only when the selected X-axis column is temporal or numeric, and configured it to reset when hidden.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43515:
URL: https://github.com/apache/superset/pull/43515#discussion_r4341086401
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/controlPanel.tsx:
##########
@@ -193,12 +195,14 @@ const config: ControlPanelConfig = {
],
[xAxisLabelRotation],
[xAxisLabelInterval],
+ [xAxisMinInterval],
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `68983c0`.
The X-axis minimum-interval control now checks the selected column type and is visible only for temporal or numeric columns.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5423519538
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5648908893
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5925098782
@gerbermichi this one had gone quiet for a month and fallen pretty far behind `master`, so I rebased it for you (clean, no conflicts) and pushed. Running CI 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-6307144451
## CodeAnt PR Risk: Medium Risk
- The PR needs attention before merging.
- For horizontal bars, verify the configured minimum intervals are swapped onto the intended rendered axes; the current axis assignments alone do not show that mapping.
**Assessed commit:** `88e06ee6398f`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43515:
URL: https://github.com/apache/superset/pull/43515#discussion_r3852797596
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1279,11 +1297,12 @@ export default function transformProps(
},
minorTick: { show: minorTicks },
minInterval:
- xAxisType === AxisType.Time && resolvedTimeGrain && !forceMaxInterval
+ parsedXAxisMinInterval ??
+ (xAxisType === AxisType.Time && resolvedTimeGrain && !forceMaxInterval
? (TIMEGRAIN_TO_TIMESTAMP[
resolvedTimeGrain as keyof typeof TIMEGRAIN_TO_TIMESTAMP
] ?? 0)
- : 0,
+ : 0),
Review Comment:
**Suggestion:** Horizontal bar charts do not swap the configured intervals before building the physical axes. With `xAxisMinInterval` set to `86400000` and `yAxisMinInterval` set to `1`, this assigns `86400000` to the rendered X/value axis and `1` to the rendered Y/category axis, contrary to the control-panel semantics and the added horizontal-bar test. Select the interval according to `isHorizontal` when assigning each axis. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Horizontal bar charts apply minimum tick spacing to opposite axes.
- ⚠️ User-configured value-axis tick granularity is ineffective.
- ⚠️ Category-axis settings may receive inappropriate intervals.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4c5ae9c298704bed82a1a58846de8204&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4c5ae9c298704bed82a1a58846de8204&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
**Line:** 1299:1305
**Comment:**
*Logic Error: Horizontal bar charts do not swap the configured intervals before building the physical axes. With `xAxisMinInterval` set to `86400000` and `yAxisMinInterval` set to `1`, this assigns `86400000` to the rendered X/value axis and `1` to the rendered Y/category axis, contrary to the control-panel semantics and the added horizontal-bar test. Select the interval according to `isHorizontal` when assigning each axis.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43515&comment_hash=5f37c5b2df97d733e8ac5582f3188dbadc90985c480c288c51fe9e38111f077f&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43515&comment_hash=5f37c5b2df97d733e8ac5582f3188dbadc90985c480c288c51fe9e38111f077f&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5410177356
<!-- Bito Reply -->
The flagged issue is correct. In `transformProps.ts`, the `minInterval` values for the X and Y axes are currently assigned directly from `xAxisMinInterval` and `yAxisMinInterval` without considering the chart's orientation. For horizontal bar charts, these should be swapped to ensure the user-configured intervals align with the correct physical axes.
To resolve this, you should update the assignment logic in `transformProps.ts` to check the `isHorizontal` flag and swap the parsed interval values accordingly before applying them to the `xAxis` and `yAxis` objects.
**superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts**
```
const parsedXAxisMinInterval = parseMinInterval(xAxisMinInterval);
const parsedYAxisMinInterval = parseMinInterval(yAxisMinInterval);
const xMinInterval = isHorizontal ? parsedYAxisMinInterval : parsedXAxisMinInterval;
const yMinInterval = isHorizontal ? parsedXAxisMinInterval : parsedYAxisMinInterval;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43515:
URL: https://github.com/apache/superset/pull/43515#issuecomment-5678583742
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(echarts): allow configuring minInterval on bar and line chart axes [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #43515:
URL: https://github.com/apache/superset/pull/43515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org