You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "r-richmond (via GitHub)" <gi...@apache.org> on 2023/03/04 06:23:05 UTC
[GitHub] [airflow] r-richmond opened a new pull request, #29915: Remove 2 outdated max constraints in Google provider
r-richmond opened a new pull request, #29915:
URL: https://github.com/apache/airflow/pull/29915
related: https://github.com/apache/airflow/issues/29901
related: https://github.com/apache/airflow/pull/29644
## What this does
Removes version max from the following 2 packages in the google provider
* google-cloud-dataflow-client
* google-cloud-dlp
## Why
* These max constraints are no longer relevant due to the this [change](https://github.com/apache/airflow/pull/29644/files#diff-b8d2d329a113cf05d9bbd18b125843e86a3ce5c3c39704d29ad58bb83bb07861L130-L132)
* I missed removing these constraints in #29644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29915: Remove 2 outdated max constraints in Google provider
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29915:
URL: https://github.com/apache/airflow/pull/29915#issuecomment-1457642662
You can build your own provider from main with breeze: https://github.com/apache/airflow/blob/main/BREEZE.rst#preparing-provider-packages and install them using .whl file generated `pip install dist/apache-airflow-providers--.....whl`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #29915: Remove 2 outdated max constraints in Google provider
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #29915:
URL: https://github.com/apache/airflow/pull/29915#issuecomment-1455471440
> @eladkal @potiuk Will this pr/Is it possible to get this pr added to current outgoing wave of provider releases?
>
> for what is is worth, I did discover this when I was asked to test my pr #29644 as part of #29901.
No. Once a releae cut we can not add anything. We cancel release to pick more fixes only in case of regression which is not the case here. This PR will wait for next release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] r-richmond commented on pull request #29915: Remove 2 outdated max constraints in Google provider
Posted by "r-richmond (via GitHub)" <gi...@apache.org>.
r-richmond commented on PR #29915:
URL: https://github.com/apache/airflow/pull/29915#issuecomment-1455461093
@eladkal @potiuk Will this pr/Is it possible to get this pr added to current outgoing wave of provider releases?
for what is is worth, I did discover this when I was asked to test my pr #29644 as part of #29901.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29915: Remove 2 outdated max constraints in Google provider
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29915:
URL: https://github.com/apache/airflow/pull/29915#discussion_r1125418664
##########
airflow/providers/google/provider.yaml:
##########
@@ -88,17 +88,13 @@ dependencies:
- google-cloud-build>=3.0.0
- google-cloud-compute>=0.1.0,<2.0.0
- google-cloud-container>=2.2.0,<3.0.0
- # google-cloud-dataflow-client of version 0.5.5 requires higher versions of
- # protobuf and proto-plus libraries which can break other dependencies in the current package.
- - google-cloud-dataflow-client>=0.5.2,<0.5.5
+ - google-cloud-dataflow-client>=0.5.2
- google-cloud-dataform>=0.2.0
- google-cloud-datacatalog>=3.0.0
- google-cloud-dataplex>=0.1.0
- google-cloud-dataproc>=3.1.0
- google-cloud-dataproc-metastore>=1.2.0,<2.0.0
- # google-cloud-dlp of version 3.8.0+ requires higher versions of
- # protobuf and proto-plus libraries which can break other dependencies in the current package.
- - google-cloud-dlp>=3.0.0,<3.8.0
+ - google-cloud-dlp>=3.0.0
Review Comment:
Was something changed since https://github.com/apache/airflow/pull/29234#discussion_r1093176100 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] r-richmond commented on pull request #29915: Remove 2 outdated max constraints in Google provider
Posted by "r-richmond (via GitHub)" <gi...@apache.org>.
r-richmond commented on PR #29915:
URL: https://github.com/apache/airflow/pull/29915#issuecomment-1456461280
On a related note is there way to specify via pip an unreleased version of a provider? (If it was a normal package I could install from GitHub and a specified branch... but given the structure of airflow providers I'm not sure how that would work).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29915: Remove 2 outdated max constraints in Google provider
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29915:
URL: https://github.com/apache/airflow/pull/29915#discussion_r1125476414
##########
airflow/providers/google/provider.yaml:
##########
@@ -88,17 +88,13 @@ dependencies:
- google-cloud-build>=3.0.0
- google-cloud-compute>=0.1.0,<2.0.0
- google-cloud-container>=2.2.0,<3.0.0
- # google-cloud-dataflow-client of version 0.5.5 requires higher versions of
- # protobuf and proto-plus libraries which can break other dependencies in the current package.
- - google-cloud-dataflow-client>=0.5.2,<0.5.5
+ - google-cloud-dataflow-client>=0.5.2
- google-cloud-dataform>=0.2.0
- google-cloud-datacatalog>=3.0.0
- google-cloud-dataplex>=0.1.0
- google-cloud-dataproc>=3.1.0
- google-cloud-dataproc-metastore>=1.2.0,<2.0.0
- # google-cloud-dlp of version 3.8.0+ requires higher versions of
- # protobuf and proto-plus libraries which can break other dependencies in the current package.
- - google-cloud-dlp>=3.0.0,<3.8.0
+ - google-cloud-dlp>=3.0.0
Review Comment:
The protobuf dependencies changed apparently in other packages - the fact that the image builds nicely and test pass are enough proof that we can remove the limits :)
And build-ci-image job nicely shows that new dlp has been used :)
> google-cloud-dlp==3.8.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29915: Remove 2 outdated max constraints in Google provider
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29915:
URL: https://github.com/apache/airflow/pull/29915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org