You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/06/03 06:27:15 UTC
[GitHub] flink pull request #4064: [FLINK-6822] Activate checkstyle for runtime/pluga...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4064
[FLINK-6822] Activate checkstyle for runtime/plugable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6822
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4064.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4064
----
commit 520bf1c237ae0fbdd646185592dc610960eaedae
Author: zentol <ch...@apache.org>
Date: 2017-06-03T06:26:34Z
[FLINK-6822] Activate checkstyle for runtime/plugable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4064: [FLINK-6822] Activate checkstyle for runtime/plugable
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4064
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4064: [FLINK-6822] Activate checkstyle for runtime/pluga...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4064#discussion_r125429424
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/plugable/ReusingDeserializationDelegate.java ---
@@ -16,33 +16,31 @@
* limitations under the License.
*/
-
package org.apache.flink.runtime.plugable;
-import java.io.IOException;
-
import org.apache.flink.api.common.typeutils.TypeSerializer;
import org.apache.flink.core.memory.DataInputView;
import org.apache.flink.core.memory.DataOutputView;
+import java.io.IOException;
+/**
+ * A {@link DeserializationDelegate} that reuses an existing instance upon deserialization.
+ */
public class ReusingDeserializationDelegate<T> implements DeserializationDelegate<T> {
-
+
private T instance;
-
+
private final TypeSerializer<T> serializer;
-
public ReusingDeserializationDelegate(TypeSerializer<T> serializer) {
this.serializer = serializer;
}
-
- @Override
--- End diff --
don't know why that happened, will revert the removal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4064: [FLINK-6822] Activate checkstyle for runtime/pluga...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4064#discussion_r120417811
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/plugable/ReusingDeserializationDelegate.java ---
@@ -16,33 +16,31 @@
* limitations under the License.
*/
-
package org.apache.flink.runtime.plugable;
-import java.io.IOException;
-
import org.apache.flink.api.common.typeutils.TypeSerializer;
import org.apache.flink.core.memory.DataInputView;
import org.apache.flink.core.memory.DataOutputView;
+import java.io.IOException;
+/**
+ * A {@link DeserializationDelegate} that reuses an existing instance upon deserialization.
+ */
public class ReusingDeserializationDelegate<T> implements DeserializationDelegate<T> {
-
+
private T instance;
-
+
private final TypeSerializer<T> serializer;
-
public ReusingDeserializationDelegate(TypeSerializer<T> serializer) {
this.serializer = serializer;
}
-
- @Override
--- End diff --
Why remove the `@Override` annotations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4064: [FLINK-6822] Activate checkstyle for runtime/plugable
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4064
@greghogan fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4064: [FLINK-6822] Activate checkstyle for runtime/pluga...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4064
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4064: [FLINK-6822] Activate checkstyle for runtime/plugable
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4064
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---