You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Fatima Khan <fa...@gmail.com> on 2017/09/30 10:17:13 UTC
Review Request 62713: RANGER 1818: Good coding practice in Ranger
recommended by static code analysis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62713/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1818
https://issues.apache.org/jira/browse/RANGER-1818
Repository: ranger
Description
-------
Good coding practice in Ranger recommended by static code analysis on the last commit made.Instead of printing the entire object we are printing only the error message that gives clear information about the error.
Diffs
-----
unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java 0b3d2e6
unixauthservice/src/main/java/org/apache/ranger/authentication/PasswordValidator.java 20ced89
Diff: https://reviews.apache.org/r/62713/diff/1/
Testing
-------
1.Tested SSO Authentication
2.Junit test was successful
Thanks,
Fatima Khan
Re: Review Request 62713: RANGER 1818: Good coding practice in Ranger
recommended by static code analysis
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62713/#review186852
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Sept. 30, 2017, 10:17 a.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62713/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2017, 10:17 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1818
> https://issues.apache.org/jira/browse/RANGER-1818
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice in Ranger recommended by static code analysis on the last commit made.Instead of printing the entire object we are printing only the error message that gives clear information about the error.
>
>
> Diffs
> -----
>
> unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java 0b3d2e6
> unixauthservice/src/main/java/org/apache/ranger/authentication/PasswordValidator.java 20ced89
>
>
> Diff: https://reviews.apache.org/r/62713/diff/1/
>
>
> Testing
> -------
>
> 1.Tested SSO Authentication
> 2.Junit test was successful
>
>
> Thanks,
>
> Fatima Khan
>
>
Re: Review Request 62713: RANGER 1818: Good coding practice in Ranger
recommended by static code analysis
Posted by Fatima Khan <fa...@gmail.com>.
> On Oct. 2, 2017, 5:44 p.m., Alejandro Fernandez wrote:
> > unixauthservice/src/main/java/org/apache/ranger/authentication/PasswordValidator.java
> > Line 117 (original), 117 (patched)
> > <https://reviews.apache.org/r/62713/diff/1/?file=1841324#file1841324line117>
> >
> > Put a space after the ","
This patch has been committed. Will get that improvement in next patch
- Fatima
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62713/#review186857
-----------------------------------------------------------
On Sept. 30, 2017, 10:17 a.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62713/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2017, 10:17 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1818
> https://issues.apache.org/jira/browse/RANGER-1818
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice in Ranger recommended by static code analysis on the last commit made.Instead of printing the entire object we are printing only the error message that gives clear information about the error.
>
>
> Diffs
> -----
>
> unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java 0b3d2e6
> unixauthservice/src/main/java/org/apache/ranger/authentication/PasswordValidator.java 20ced89
>
>
> Diff: https://reviews.apache.org/r/62713/diff/1/
>
>
> Testing
> -------
>
> 1.Tested SSO Authentication
> 2.Junit test was successful
>
>
> Thanks,
>
> Fatima Khan
>
>
Re: Review Request 62713: RANGER 1818: Good coding practice in Ranger
recommended by static code analysis
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62713/#review186857
-----------------------------------------------------------
Fix it, then Ship it!
unixauthservice/src/main/java/org/apache/ranger/authentication/PasswordValidator.java
Line 117 (original), 117 (patched)
<https://reviews.apache.org/r/62713/#comment263698>
Put a space after the ","
- Alejandro Fernandez
On Sept. 30, 2017, 10:17 a.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62713/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2017, 10:17 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1818
> https://issues.apache.org/jira/browse/RANGER-1818
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Good coding practice in Ranger recommended by static code analysis on the last commit made.Instead of printing the entire object we are printing only the error message that gives clear information about the error.
>
>
> Diffs
> -----
>
> unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java 0b3d2e6
> unixauthservice/src/main/java/org/apache/ranger/authentication/PasswordValidator.java 20ced89
>
>
> Diff: https://reviews.apache.org/r/62713/diff/1/
>
>
> Testing
> -------
>
> 1.Tested SSO Authentication
> 2.Junit test was successful
>
>
> Thanks,
>
> Fatima Khan
>
>