You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/04/02 22:29:14 UTC

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9892


Change subject: IMPALA-6776: Increase region move timeout.
......................................................................

IMPALA-6776: Increase region move timeout.

Some builds are experiencing slow HBase region moves in the
test minicluster. Trying to increase the timeout from 10s to 60s.

Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
---
M testdata/src/compat-minicluster-profile-3/java/org/apache/impala/datagenerator/HBaseTestDataRegionAssigment.java
1 file changed, 13 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/9892/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9892 )

Change subject: IMPALA-6776: Increase region move timeout.
......................................................................

IMPALA-6776: Increase region move timeout.

Some builds are experiencing slow HBase region moves in the
test minicluster. Trying to increase the timeout from 10s to 60s.

Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Reviewed-on: http://gerrit.cloudera.org:8080/9892
Reviewed-by: Zach Amsden <za...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M testdata/src/compat-minicluster-profile-3/java/org/apache/impala/datagenerator/HBaseTestDataRegionAssigment.java
1 file changed, 13 insertions(+), 6 deletions(-)

Approvals:
  Zach Amsden: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9892 )

Change subject: IMPALA-6776: Increase region move timeout.
......................................................................


Patch Set 1:

I've run the tests with this change, and nothing looked wrong. It was also inconclusive in that the log entries I looked at had this completing in well under 10seconds, but it seems like waiting a little bit longer isn't going to hurt.


-- 
To view, visit http://gerrit.cloudera.org:8080/9892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Apr 2018 22:29:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9892 )

Change subject: IMPALA-6776: Increase region move timeout.
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 21:41:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9892 )

Change subject: IMPALA-6776: Increase region move timeout.
......................................................................


Patch Set 1: Code-Review+2

Seems fine; it seems weirdly coincidental that so far all of the failed moves have happened on the first part of the keyspace.


-- 
To view, visit http://gerrit.cloudera.org:8080/9892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 00:22:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6776: Increase region move timeout.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9892 )

Change subject: IMPALA-6776: Increase region move timeout.
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2228/


-- 
To view, visit http://gerrit.cloudera.org:8080/9892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic62719f1b1aad463bcdc18d0803e780ebb0f8b18
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Apr 2018 17:45:07 +0000
Gerrit-HasComments: No