[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9563: add encrypt cases of ddl and simplify configuration

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #9563:
URL: https://github.com/apache/shardingsphere/pull/9563#discussion_r587124038



##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/env/encrypt/init-sql/mysql/init.sql
##########
@@ -26,5 +26,5 @@ DROP DATABASE IF EXISTS encrypt;
 CREATE DATABASE encrypt;
 
 CREATE TABLE encrypt.t_user (user_id INT NOT NULL, pwd_plain VARCHAR(45) NULL, pwd_cipher VARCHAR(45) NULL, PRIMARY KEY (user_id));
-CREATE TABLE encrypt.t_order_item (item_id INT NOT NULL, order_id INT NOT NULL, user_id INT NOT NULL, status VARCHAR(45) NULL, creation_date DATE, PRIMARY KEY (item_id));
+CREATE TABLE encrypt.t_user_item (item_id INT NOT NULL, order_id INT NOT NULL, user_id INT NOT NULL, status VARCHAR(45) NULL, creation_date DATE, PRIMARY KEY (item_id));
 CREATE INDEX user_index_t_user ON encrypt.t_user (user_id);

Review comment:
       A new line is required below.

##########
File path: shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/resources/cases/ddl/dataset/encrypt/change_user_table.xml
##########
@@ -0,0 +1,24 @@
+<!--

Review comment:
       I assume `alter_user_user` is better to name this file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org