You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by chenliang613 <gi...@git.apache.org> on 2017/01/13 09:16:33 UTC

[GitHub] incubator-carbondata pull request #534: [CARBONDATA-632] Fix wrong comments ...

GitHub user chenliang613 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/534

    [CARBONDATA-632] Fix wrong comments of load data in CarbonDataRDDFactory.scala

    Fix wrong comments of load data in CarbonDataRDDFactory.scala:
    1.Currently, not use NewHadoopRDD and DummyLoadRDD
    2.Clean invalid code:
    inputFormat match
    { case configurable: Configurable => configurable.setConf(hadoopConfiguration) case _ => }

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenliang613/incubator-carbondata refine_code

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #534
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #534: [CARBONDATA-632] Fix wrong comments of load...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/534
  
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/598/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #534: [CARBONDATA-632] Fix wrong comments of load...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/534
  
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/588/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #534: [CARBONDATA-632] Fix wrong comments ...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/534#discussion_r96002854
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -559,11 +560,7 @@ object CarbonDataRDDFactory {
               CommonUtil.configSplitMaxSize(sqlContext.sparkContext, filePaths, hadoopConfiguration)
     
               val inputFormat = new org.apache.hadoop.mapreduce.lib.input.TextInputFormat
    -          inputFormat match {
    -            case configurable: Configurable =>
    -              configurable.setConf(hadoopConfiguration)
    -            case _ =>
    -          }
    +
    --- End diff --
    
    This empty line can be removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #534: [CARBONDATA-632] Fix wrong comments of load...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/534
  
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/600/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #534: [CARBONDATA-632] Fix wrong comments ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/534


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata issue #534: [CARBONDATA-632] Fix wrong comments of load...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/534
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---