You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/11 04:19:25 UTC

[GitHub] [pulsar] Jason918 commented on a diff in pull request #16008: [fix][env] Support the java version like 'XX-internal' in env file

Jason918 commented on code in PR #16008:
URL: https://github.com/apache/pulsar/pull/16008#discussion_r894974404


##########
conf/pulsar_env.sh:
##########
@@ -60,6 +60,9 @@ for token in $("$JAVA_BIN" -version 2>&1 | grep 'version "'); do
           JAVA_MAJOR_VERSION=${BASH_REMATCH[1]}
         fi
         break
+    elif [[ $token =~ \"([[:digit:]]+)(.*)\" ]]; then

Review Comment:
   It would be nice to add some comment about this case here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org