You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/10/30 02:00:03 UTC
[GitHub] [phoenix] kadirozde commented on a change in pull request #614: PHOENIX-5553: Transactional views should not get GlobalIndexChecker c…
kadirozde commented on a change in pull request #614: PHOENIX-5553: Transactional views should not get GlobalIndexChecker c…
URL: https://github.com/apache/phoenix/pull/614#discussion_r340401972
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -927,7 +928,16 @@ private void addCoprocessors(byte[] tableName, TableDescriptorBuilder builder, P
boolean isViewIndex = TRUE_BYTES_AS_STRING
.equals(tableProps.get(MetaDataUtil.IS_VIEW_INDEX_TABLE_PROP_NAME));
- if ((tableType == PTableType.INDEX && !isTransactional) || isViewIndex) {
+ boolean isViewBaseTransactional = false;
+ if (!isTransactional && isViewIndex) {
+ if (tableProps.containsKey(TRANSACTIONAL) &&
+ Boolean.TRUE.equals(tableProps.get(TRANSACTIONAL))) {
+ isViewBaseTransactional = true;
+ }
+ }
+
+ if (!isTransactional && !isViewBaseTransactional
Review comment:
Do we need to introduce a separate variable, i.e., isViewBaseTransactional? Would not the following work?
If (!isTransactional && (PTableType.INDEX || isViewIndex) {
I think we have a test to check coprocessors on a table for the new index design. Can we update the test for view indexes too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services