You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/07 04:04:53 UTC

[GitHub] [apisix-dashboard] gxthrj opened a new issue #715: [Proposal]Standardize project output documents and simplify the way of making install

gxthrj opened a new issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715


   1. Distinguish development documents & deployment documents;
   2. Independently compiled directory structure;
   3. Unified management dashboard and manager-api packaging method (independent & combined);


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723448212


   > Do not. Why are installation and build mixed together?
   
   my mistake , there is no installation, just build. 
   we use makefile to build a package , the dir `build` is where the tar package is located.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723523192


   my opinion of root folder:
   
   1. one makefile
   2. no `build` dir: when build, will create this folder automatically.
   3. `web` vs `dashboard`: I can not sure which one is better.
   4. `.actions` is not a good name, we need a better one
   
   ```
   apisix-dashboard
   ├── .actions # need a better name
   ├── .github
   ├── README.md
   ├── api
   │   └── ...
   ├── web
   │   └── ...
   ├── docs
   └── makefile
   ```
   
   @gxthrj please pay more attention to the folder of `api`. The problem with this directory is more serious.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723447734


   Do not.  Why are installation and build mixed together?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723542671


   > If you want to only build the manager api, just passed some arguments when building the image by using the root dockerfile.
   > 
   > Right? @membphis
   
   yes, that is the right way I prefer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723449663


   > Why are there three Makefile? I think one in root dir is enough.
   
   There are two considerations
   1. I hope that the sub projects can be packaged and released independently;
   2. The makefile of the root directory is configured with different commands according to the needs, regardless of the packaging logic of subprojects;


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-751969508


   done?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723464572


   1. We don't have `.action`, we have `.actions`.
   2. `.actions` is not clear for users,  it should be renamed in this reconstruction work.
   3. In this proposal, you only create 3 makefile files and rename the final product directory from `output` to `build`, I don't think it's better than before.
   4. We don't have a plan to release the frontend & the backend separately, so 1 root makefile is fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj closed issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj closed issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723451119


   I just remove the dir `build` in the comment before


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723525187


   there is a questions, We have designed two `dockerfile` for both api and dashboard. I think the reason for this is because we need to build the image independently.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723526964






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723538592


   Also, as far as know, the dockerfile under the api folder is used to do test, it seems that you don't have enough commuting with chen. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723464572


   1. We don't have `.action`, we have `.actions`.
   2. `.actions` is not clear for users,  it should be renamed in this refactor.
   3. In this proposal, you only create 3 makefile files and rename the final product directory from `output` to `build`, I don't think it's better than before.
   4. We don't have a plan to release the frontend & the backend separately, so 1 root makefile is fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723538375


   So why there will have multiple Dockerfile files? This doesn't make sense and it's unacceptable for me!
   
   If you want to only build the manager api, just passed some arguments when building the image by using the root dockerfile. 
   
   Right? @membphis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723533080


   > > there is a questions, We have designed two `dockerfile` for both api and dashboard. I think the reason for this is because we need to build the image independently.
   > 
   > Nop, the Dockerfile under the `api` directory is used to run the test according to @nic-chen, just moved it under the test directory or somewhere else.
   
   for now , the content of `/api/Dockerfile` is building api image,but the `docker-compose.yaml` is for test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723448580


   Build tar package with Makefile, and the running mode will be described in readme


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723526401


   I don't want the dashboard and API to be built independently.
   
   For users, they can choose only API, or dashboard + API, nothing else.
   
   Within a single Dockfile, use parameters as conditions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj edited a comment on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj edited a comment on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723446494


   I recommend turning the project into a directory structure like this
   ```
   apisix-dashboard
   ├── .action
   ├── .github
   ├── README.md
   ├── api
   │   └── makefile
   ├── build
   │   ├── rpms
   │   └── tars
   ├── dashboard
   │   └── makefile
   ├── docs
   └── makefile
   ```
   
   1. The root directory only contains:
   
   | file | type | desc |
   |-----------| -----------| -----------| 
   |README.md | file | Project Introduction|
   |makefile | file | The makefile in the root directory standardizes the overall packaging process, and the makefile in the subproject is called |
   | api | dir | the logic of manager-api|
   |dashboard | dir | the logic of dashboard UI |
   | build | dir | Compilation results, such as a tar package that can be decompressed and run|
   
   2. There are respective makefiles in the api and dashboard, which are responsible for their respective construction work.
   
   what do you think ? @juzhiyuan @justinmclean @membphis @moonming 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj edited a comment on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj edited a comment on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723446494


   I recommend turning the project into a directory structure like this
   ```
   apisix-dashboard
   ├── .actions
   ├── .github
   ├── README.md
   ├── api
   │   └── makefile
   ├── dashboard
   │   └── makefile
   ├── docs
   └── makefile
   ```
   
   1. The root directory only contains:
   
   | file | type | desc |
   |-----------| -----------| -----------| 
   |README.md | file | Project Introduction|
   |makefile | file | The makefile in the root directory standardizes the overall packaging process, and the makefile in the subproject is called |
   | api | dir | the logic of manager-api|
   |dashboard | dir | the logic of dashboard UI |
   | build | dir | Compilation results, such as a tar package that can be decompressed and run|
   
   2. There are respective makefiles in the api and dashboard, which are responsible for their respective construction work.
   
   what do you think ? @juzhiyuan @justinmclean @membphis @moonming 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj edited a comment on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj edited a comment on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723449663


   > Why are there three Makefile? I think one in root dir is enough.
   
   There are two considerations
   1. I hope that the sub projects can be packaged and released independently;
   2. The makefile of the root directory is the orchestration with different commands, regardless of the packaging logic of subprojects;


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723526964


   > there is a questions, We have designed two `dockerfile` for both api and dashboard. I think the reason for this is because we need to build the image independently.
   
   Nop, the Dockerfile under the `api` directory is used to run the test according to @nic-chen, just moved it under the test directory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723542779


   > the dockfile need to be modify too
   
   let us update it. the current way is not good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723510160


   > 1. We don't have `.action`, we have `.actions`.
   > 2. `.actions` is not clear for users,  it should be renamed in this reconstruction work.
   > 3. In this proposal, you only create 3 makefile files and rename the final product directory from `output` to `build`, I don't think it's better than before.
   > 4. We don't have a plan to release the frontend & the backend separately, so 1 root makefile is fine.
   
   1. I just update the comment before: .action -> .actions, but I think the `.actions` is ok. 
   2. There are indeed many root directories in our dashboard, which is really confusing for novices, it will be more clearer to separate the project files.
   3. one makefile is ok,but separate makefile for easy maintenance of front-end and back-end.
   4. We have a scenario where only the admin-api installation package is needed, and dashboard is just one of the projects that rely on manager-api.
   5. This is just a proposal that hopes to make the project directory clear,If reasonable, we can make a plan and do it step by step in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723512397


   1. Why .actions is ok? Is it clear for you when you see it in the first time?
   
   2. If only the manager api is needed, why not update the repo's name to manager-api?
   
   3. From your long long description, you mean it's ok to use 1 makefile or 3 makefile, then just kept the 1 makefile.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-759856668


   I think we can close this issue now, feel free to reopen if have any problems.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723446728


   We don’t need the build dir, this repo only has source codes
   
   kv <no...@github.com>于2020年11月7日 周六下午9:29写道:
   
   > I recommend turning the project into a directory structure like this
   >
   > apisix-dashboard
   >
   > ├── .action
   >
   > ├── .github
   >
   > ├── README.md
   >
   > ├── api
   >
   > │   └── makefile
   >
   > ├── build
   >
   > │   ├── rpms
   >
   > │   └── tars
   >
   > ├── dashboard
   >
   > │   └── makefile
   >
   > ├── docs
   >
   > └── makefile
   >
   >
   >
   >    1. The root directory only contains:
   >    2. The root directory only contains:
   >
   > file type desc
   > README.md file Project Introduction
   > makefile file The makefile in the root directory standardizes the overall
   > packaging process, and the makefile in the subproject is called
   > api dir the logic of manager-api
   > dashboard dir the logic of dashboard UI
   > build dir Compilation results, such as a tar package that can be
   > decompressed and run
   >
   >    1. There are respective makefiles in the api and dashboard, which are
   >    responsible for their respective construction work.
   >
   > what do you think ? @juzhiyuan <https://github.com/juzhiyuan>
   > @justinmclean <https://github.com/justinmclean> @membphis
   > <https://github.com/membphis> @moonming <https://github.com/moonming>
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723446494>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBK4FL5BGRYW4PQOO4GDSOVDTVANCNFSM4TNMVSAQ>
   > .
   >
   -- 
   Thanks,
   Ming Wen
   Twitter: _WenMing
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723527147


   > @juzhiyuan please give a suggest for renaming `.actions`
   
   Just like workflows, actions are under the .github directory, just renamed it to `.apache` or `.asf`.
   
   `tools` or `utils` are not good for me IMO.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723525452


   @juzhiyuan please give a  suggest for renaming `.actions`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723527232


   > web vs dashboard: I can not sure which one is better.
   
   @membphis `web` is fine because this repo's name is `apisix-dashboard`, so we don't need to wrap a `dashboard` subdirectory just for the frontend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723447143


   ok, we can create  dir `build` when make install 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723449050


   Why are there three Makefile? I think one in root dir is enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723522040


   > > Why are there three Makefile? I think one in root dir is enough.
   > 
   > There are two considerations
   > 
   > 1. I hope that the sub projects can be packaged and released independently;
   > 2. The makefile of the root directory is the orchestration with different commands, regardless of the packaging logic of subprojects;
   
   one `makefile` can do this too. just use different commands.  you can take a look at the makefile of APISIX.
   
   ```sh
   $ make help
   Makefile rules:
   
       help:             Show Makefile rules
       deps:             Installation dependencies
       utils:            Installation tools
       lint:             Lint Lua source code
       init:             Initialize the runtime environment
       run:              Start the apisix server
       stop:             Stop the apisix server
       verify:           Verify the configuration of apisix server
       clean:            Remove generated files
       reload:           Reload the apisix server
       install:          Install the apisix (only for luarocks)
       test:             Run the test case
       license-check:    Check Lua source code for Apache License
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723526003


   > there is a questions, We have designed two `dockerfile` for both api and dashboard. I think the reason for this is because we need to build the image independently.
   
   We have reached a consensus before that there is only one dockerfile


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723527147


   > @juzhiyuan please give a suggest for renaming `.actions`
   
   Just like workflows, actions are under the .github directory, just renamed it to `.apache`.
   
   `tools` or `utils` are not good for me IMO.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723542675


   > Also, as far as know, the dockerfile under the api folder is used to do test, it seems that you don't have enough commuting with chen.
   
   just see the code of dockerfile, it is for building image
   and Keep unity ,there will be only one dockerfile and one makefile,the dockfile need to be modify too
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723446494


   I recommend turning the project into a directory structure like this
   ```
   apisix-dashboard
   ├── .action
   ├── .github
   ├── README.md
   ├── api
   │   └── makefile
   ├── build
   │   ├── rpms
   │   └── tars
   ├── dashboard
   │   └── makefile
   ├── docs
   └── makefile
   ```
   
   1. The root directory only contains:
   1. The root directory only contains:
   
   | file | type | desc |
   |-----------| -----------| -----------| 
   |README.md | file | Project Introduction|
   |makefile | file | The makefile in the root directory standardizes the overall packaging process, and the makefile in the subproject is called |
   | api | dir | the logic of manager-api|
   |dashboard | dir | the logic of dashboard UI |
   | build | dir | Compilation results, such as a tar package that can be decompressed and run|
   
   2. There are respective makefiles in the api and dashboard, which are responsible for their respective construction work.
   
   what do you think ? @juzhiyuan @justinmclean @membphis @moonming 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj edited a comment on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
gxthrj edited a comment on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723446494


   I recommend turning the project into a directory structure like this
   ```
   apisix-dashboard
   ├── .action
   ├── .github
   ├── README.md
   ├── api
   │   └── makefile
   ├── dashboard
   │   └── makefile
   ├── docs
   └── makefile
   ```
   
   1. The root directory only contains:
   
   | file | type | desc |
   |-----------| -----------| -----------| 
   |README.md | file | Project Introduction|
   |makefile | file | The makefile in the root directory standardizes the overall packaging process, and the makefile in the subproject is called |
   | api | dir | the logic of manager-api|
   |dashboard | dir | the logic of dashboard UI |
   | build | dir | Compilation results, such as a tar package that can be decompressed and run|
   
   2. There are respective makefiles in the api and dashboard, which are responsible for their respective construction work.
   
   what do you think ? @juzhiyuan @justinmclean @membphis @moonming 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on issue #715: [Proposal]Standardize project output documents and simplify the way of making install

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #715:
URL: https://github.com/apache/apisix-dashboard/issues/715#issuecomment-751978548


   ping @gxthrj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org