You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/05/15 14:58:54 UTC
[GitHub] [helix] desaikomal opened a new pull request, #2486: Small bug fixes related to ZK disconnect and timeouts
desaikomal opened a new pull request, #2486:
URL: https://github.com/apache/helix/pull/2486
### Issues
- [] My PR addresses the following Helix issues and references them in the PR description:
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
- Small bug fixes related to ZK disconnect.
We added the fix where we retry with exponential backoff.
There are some new failures in the test because tests have become underministic wrt time to wait.
So let us remove randomness by explicitly waiting for thread to join.
Also, retryCount should start with 0 and then increment it.
This is the same behavior in other Exponential backoff call in other ZK API.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Testing Done: mvn test (in zookeeper-api as well as helix-core)
[ERROR] Failures:
[ERROR] TestNoThrottleDisabledPartitions.testDisablingTopStateReplicaByDisablingInstance:98 expected:<false> but was:<true>
[ERROR] TestNoThrottleDisabledPartitions.testNoThrottleOnDisabledInstance:231->setupEnvironment:317->setupCluster:436 ยป ZkClient
[ERROR] TestP2PNoDuplicatedMessage.testP2PStateTransitionEnabled:180 expected:<true> but was:<false>
[ERROR] TestStateTransitionTimeout.testStateTransitionTimeOut:170 expected:<true> but was:<false>
[ERROR] TestWagedRebalanceTopologyAware.testAddZone:112->TestWagedRebalanceFaultZone.testAddZone:288 expected:<true> but was:<false>
[ERROR] Tests run: 1326, Failures: 5, Errors: 0, Skipped: 0
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu merged pull request #2486: Small bug fixes related to ZK disconnect and timeouts
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2486:
URL: https://github.com/apache/helix/pull/2486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2486: Small bug fixes related to ZK disconnect and timeouts
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2486:
URL: https://github.com/apache/helix/pull/2486#issuecomment-1548885190
This change has been reviewed and approved by @xyuanlu. Thanks Xiaoyuan.
Commit message - with exponential backoff in retry logic, test had become flaky. Explicitly wait for thread to join and remove the randomness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2486: Small bug fixes related to ZK disconnect and timeouts
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2486:
URL: https://github.com/apache/helix/pull/2486#issuecomment-1548714403
@xyuanlu - the PR-CI passed except
2023-05-15T22:23:44.0176275Z java.lang.AssertionError: expected:
org.apache.helix.rest.server.TestJobAccessor.testDeleteJob(TestJobAccessor.java:207)
There is a known problem:
https://github.com/apache/helix/issues/2412
Can you please help review the change? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2486: Small bug fixes related to ZK disconnect and timeouts
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2486:
URL: https://github.com/apache/helix/pull/2486#discussion_r1194357431
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -1968,7 +1968,7 @@ public <T> T retryUntilConnected(final Callable<T> callable)
if (_monitor != null) {
_monitor.increaseOutstandingRequestGauge();
}
- int retryCount = 1;
+ int retryCount = 0;
Review Comment:
Earlier and now too, we retry. The only difference is after failure, how long do we wait. Prior to exponential back-off, we didn't wait at all. Now we wait for whatever is the time ExponentialBackOff strategy calculates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a diff in pull request #2486: Small bug fixes related to ZK disconnect and timeouts
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu commented on code in PR #2486:
URL: https://github.com/apache/helix/pull/2486#discussion_r1194342800
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -1968,7 +1968,7 @@ public <T> T retryUntilConnected(final Callable<T> callable)
if (_monitor != null) {
_monitor.increaseOutstandingRequestGauge();
}
- int retryCount = 1;
+ int retryCount = 0;
Review Comment:
Thanks for working on the fix!
Changing retryCount does it mean we start retry immediately after we get error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org