You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/03/16 15:31:30 UTC
[GitHub] chetanmeh opened a new pull request #3453: [wip] Introduce a AttachmentStore SPI
chetanmeh opened a new pull request #3453: [wip] Introduce a AttachmentStore SPI
URL: https://github.com/apache/incubator-openwhisk/pull/3453
Introduces a new SPI `AttachmentStore` with a `MemoryAttachmentStore`
## Description
This PR proposes a new `AttachmentStore` SPI with a `MemoryAttachmentStore` as an initial implementation. As part of this PR following aspect would be covered
1. Capture the SPI contract as part of `AttachmentStoreBehaviors` test specification. This suite would need to be passed by all SPI implementations
2. Refactor the current `CouchDbRestStore` and extract a `CouchDbAttachmentStore`. This would later enable plugging in a custom store
3. Possibly implement another store based on S3/Azure/IBM Objects etc
## Related issue and scope
- [x] I opened an issue to propose and discuss this change (#3450)
## My changes affect the following components
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [x] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [x] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services