[GitHub] mkuthan commented on a change in pull request #6493: Support for request logging in kafka emitter.

[GitBox <gi...@apache.org>]

mkuthan commented on a change in pull request #6493: Support for request logging in kafka emitter.
URL: https://github.com/apache/incubator-druid/pull/6493#discussion_r239107804
 
 

 ##########
 File path: extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitterConfig.java
 ##########
 @@ -47,13 +49,15 @@ public KafkaEmitterConfig(
       @JsonProperty(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG) String bootstrapServers,
       @JsonProperty("metric.topic") String metricTopic,
       @JsonProperty("alert.topic") String alertTopic,
+      @JsonProperty("request.topic") String requestTopic,
       @JsonProperty("clusterName") String clusterName,
       @JsonProperty("producer.config") @Nullable Map<String, String> kafkaProducerConfig
   )
   {
     this.bootstrapServers = Preconditions.checkNotNull(bootstrapServers, "bootstrap.servers can not be null");
     this.metricTopic = Preconditions.checkNotNull(metricTopic, "metric.topic can not be null");
     this.alertTopic = Preconditions.checkNotNull(alertTopic, "alert.topic can not be null");
+    this.requestTopic = Preconditions.checkNotNull(requestTopic, "request.topic can not be null");
 
 Review comment:
   We should be consistent with all 3 topics and make all of them required or optional, e.g. it is fully valid scenario when we are interested in metrics but not in alerts. 
   
   I agree that should be a waring if emitter receives event but corresponding topic is not configured.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org