You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/29 13:05:53 UTC
[GitHub] [rocketmq] xujianhai666 commented on a change in pull request
#1734: [ISSUE #1727] fix RequestCallback executed multi times
xujianhai666 commented on a change in pull request #1734: [ISSUE #1727] fix RequestCallback executed multi times
URL: https://github.com/apache/rocketmq/pull/1734#discussion_r386027093
##########
File path: client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java
##########
@@ -39,7 +41,7 @@ public RequestResponseFuture(String correlationId, long timeoutMillis, RequestCa
}
public void executeRequestCallback() {
- if (requestCallback != null) {
+ if (requestCallback != null && executeCallbackOnlyOnce.compareAndSet(false, true)) {
Review comment:
code has change. see latest code: `if (sendRequestOk && cause == null) {`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services