You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Standing-Man (via GitHub)" <gi...@apache.org> on 2025/03/08 07:08:28 UTC
[PR] implement tree rendering for StreamingTableExec [datafusion]
Standing-Man opened a new pull request, #15085:
URL: https://github.com/apache/datafusion/pull/15085
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes part of #14914.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
implement tree rendering for StreamingTableExec
## Are these changes tested?
yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] implement tree rendering for StreamingTableExec [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #15085:
URL: https://github.com/apache/datafusion/pull/15085#discussion_r1986063867
##########
datafusion/physical-plan/src/streaming.rs:
##########
@@ -209,8 +209,27 @@ impl DisplayAs for StreamingTableExec {
Ok(())
}
DisplayFormatType::TreeRender => {
- // TODO: collect info
- write!(f, "")
+ write!(
Review Comment:
Per the description of TreeRender:
https://github.com/apache/datafusion/blob/3dc212c9078c92f57ab7f58e75e1258130c772d0/datafusion/physical-plan/src/display.rs#L48-L74
TreeRender mode should have only the most relevant details for understanding the high level plan
In this case I think the the important data is if the source is infinite as well as something about StreamingSource
Can you please update this so only `infinite=<value>` is shown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] implement tree rendering for StreamingTableExec [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #15085:
URL: https://github.com/apache/datafusion/pull/15085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] implement tree rendering for StreamingTableExec [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #15085:
URL: https://github.com/apache/datafusion/pull/15085#issuecomment-2710152588
I also verified the tests pass after merging to main locally. Thanks again @Standing-Man
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] implement tree rendering for StreamingTableExec [datafusion]
Posted by "Standing-Man (via GitHub)" <gi...@apache.org>.
Standing-Man commented on code in PR #15085:
URL: https://github.com/apache/datafusion/pull/15085#discussion_r1986479692
##########
datafusion/physical-plan/src/streaming.rs:
##########
@@ -209,8 +209,27 @@ impl DisplayAs for StreamingTableExec {
Ok(())
}
DisplayFormatType::TreeRender => {
- // TODO: collect info
- write!(f, "")
+ write!(
Review Comment:
So we only need to show `infinite` and `limit` information there?
```
pub struct StreamingTableExec {
partitions: Vec<Arc<dyn PartitionStream>>,
projection: Option<Arc<[usize]>>,
projected_schema: SchemaRef,
projected_output_ordering: Vec<LexOrdering>,
infinite: bool,
limit: Option<usize>,
cache: PlanProperties,
metrics: ExecutionPlanMetricsSet,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org