You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Thomas Weise (JIRA)" <ji...@apache.org> on 2017/04/11 02:52:42 UTC

[jira] [Resolved] (BEAM-1832) Potentially unclosed OutputStream in ApexYarnLauncher

     [ https://issues.apache.org/jira/browse/BEAM-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Weise resolved BEAM-1832.
--------------------------------
       Resolution: Fixed
    Fix Version/s: First stable release

> Potentially unclosed OutputStream in ApexYarnLauncher
> -----------------------------------------------------
>
>                 Key: BEAM-1832
>                 URL: https://issues.apache.org/jira/browse/BEAM-1832
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-apex
>            Reporter: Ted Yu
>            Priority: Minor
>             Fix For: First stable release
>
>
> Here is an example from createJar():
> {code}
>       final OutputStream out = Files.newOutputStream(zipfs.getPath(JarFile.MANIFEST_NAME));
>       if (!manifestFile.exists()) {
>         new Manifest().write(out);
>       } else {
>         FileUtils.copyFile(manifestFile, out);
>       }
>       out.close();
> {code}
> If FileUtils.copyFile throws IOException, out would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)