You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/23 07:21:31 UTC
[GitHub] [arrow] kou opened a new pull request, #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
kou opened a new pull request, #15075:
URL: https://github.com/apache/arrow/pull/15075
If `ARROW_BUILD_SHARED=OFF` is specified, `pkg-config --cflags --libs arrow` doesn't work. Because `pkg-config --cflags --libs arrow` misses build options for static linking. Users need to specify `pkg-config --cflags --libs --static arrow` for static linking even when `ARROW_BUILD_SHARED=OFF` is specified.
This change adds support for `pkg-config --cflags --libs arrow` with `ARROW_BUILD_SHARED=OFF`. The command outputs build options for linking against `libarrow.a`. But these build options don't use static linking for dependencies. On the other hand, `pkg-config --cflags --libs --static arrow` still use static linking for all libraries including Apache Arrow C++ and its dependencies.
With this change, Apache Arrow R doesn't need to use `pkg-config --static`. Because `pkg-config --cflags --libs arrow` works for both of `libarrow.so` and `libarrow.a`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1365663124
Benchmark runs are scheduled for baseline = 130f41afabd90d6ee67d01b1fb0865eccfc98e7e and contender = 43b95e6e01d2bb411a1cc04b6f3f6c07c615b34f. 43b95e6e01d2bb411a1cc04b6f3f6c07c615b34f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4ef9e214e64e4e759be2b516ab7451b4...22a33bf9a0304991ac31a71e7f1089e6/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b362a74acd2c4ae2a9eb75a1853de598...d8dae574ffb146f28015caae3b8f6cac/)
[Finished :arrow_down:2.3% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76fcbed0bfbd48a1bae588d895f4bb70...32f50ca606324cde90826c402811f92f/)
[Finished :arrow_down:2.24% :arrow_up:0.89%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4c5727c372b64d959f93342a270df767...1654e0c4c9064d5b9e0c2e91e3ee6a50/)
Buildkite builds:
[Finished] [`43b95e6e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2069)
[Failed] [`43b95e6e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2091)
[Finished] [`43b95e6e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2063)
[Finished] [`43b95e6e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2083)
[Finished] [`130f41af` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2068)
[Failed] [`130f41af` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2090)
[Finished] [`130f41af` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2062)
[Finished] [`130f41af` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2082)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
kou merged PR #15075:
URL: https://github.com/apache/arrow/pull/15075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1364359391
Revision: a9f43475ba0f909b01a6c03e529bfa655e93e609
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f0dd31f2ff](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f0dd31f2ff)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/3768457003/jobs/6406907657)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1365663284
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76fcbed0bfbd48a1bae588d895f4bb70...32f50ca606324cde90826c402811f92f/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
kou commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1365545668
I merge this. If there are problems, I'll fix them in follow-up pull requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
kou commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1364417755
This is ready to review/merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
kou commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1364358319
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
kou commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1363794269
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1363688696
* Closes: #15040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1363796083
Revision: 9df548ae8678d789691dbeafcbf1fa306a0bbe17
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3816077063](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3816077063)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/3764740979/jobs/6399491857)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1364377916
Revision: 62e7a27a08a14e69b120ee3794de872c36debe8e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-67a83aaaad](https://github.com/ursacomputing/crossbow/branches/all?query=actions-67a83aaaad)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/3768722919/jobs/6407376010)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
kou commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1364377163
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1363733318
Revision: 9df548ae8678d789691dbeafcbf1fa306a0bbe17
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f48dce693b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f48dce693b)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/10270471986)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/10270466516)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/10270479921)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/10270467066)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/10270485589)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/10270492943)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/10270469970)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/10270472819)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/10270490586)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/3764291448/jobs/6398577169)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/3764294391/jobs/6398582640)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/3764292632/jobs/6398584965)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/10270489104)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/3764290374/jobs/6398574662)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/10270491462)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/3764296084/jobs/6398586091)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/3764293222/jobs/6398580419)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/3764296669/jobs/6398587388)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/3764293800/jobs/6398581463)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/3764295809/jobs/6398585459)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/3764297523/jobs/6398589146)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/3764295237/jobs/6398584425)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/10270481998)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/3764292312/jobs/6398579052)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/3764294631/jobs/6398583147)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/10270492153)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/10270487732)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/3764289649/jobs/6398573486)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/10270487181)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/10270466798)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/10270474055)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/10270469075)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/10270471342)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/10270477107)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/10270467919)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/3764292048/jobs/6398578145)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/3764295549/jobs/6398585228)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/10270478702)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1364324222
Revision: fd60bc7b5689ffa1df5af26bafc442662f67d4bf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-46b65e2722](https://github.com/ursacomputing/crossbow/branches/all?query=actions-46b65e2722)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/3768144740/jobs/6406333846)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
kou commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1364323436
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #15075: GH-15040: [C++] Improve pkg-config support for ARROW_BUILD_SHARED=OFF
Posted by GitBox <gi...@apache.org>.
kou commented on PR #15075:
URL: https://github.com/apache/arrow/pull/15075#issuecomment-1363730178
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org