You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by aaltay <gi...@git.apache.org> on 2016/12/02 21:50:17 UTC

[GitHub] incubator-beam pull request #1491: [BEAM-1070] Call from_p12_keyfile() with ...

GitHub user aaltay opened a pull request:

    https://github.com/apache/incubator-beam/pull/1491

    [BEAM-1070] Call from_p12_keyfile() with the correct arguments

    This code path is failing, because a wrong list of arguments is passed.
    Fixing that uncovered that oauth2client depends on pyOpenSSL for this
    call to work. I did not add this dependency to setup.py because, it does
    not install cleanly in all environments.
    
    As a workaround, users who would like to use this authentication method
    could first do a 'pip install pyOpenSSL'. I added a test, that skips if 'pyOpenSSL' is not installed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaltay/incubator-beam serkey

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1491
    
----
commit db9e3c7b1ec515789b9531e013669ae621646aaf
Author: Ahmet Altay <al...@google.com>
Date:   2016-12-02T21:38:31Z

    Call from_p12_keyfile() with the correct arguments.
    
    This code path is failing, because a wrong list of arguments is passed.
    Fixing that uncovered that oauth2client depends on pyOpenSSL for this
    call to work. I did not add this dependency to setup.py because, it does
    not install cleanly in all environments.
    
    As a workaround, users who would like to use this authentication method
    could first do a 'pip install pyOpenSSL'. I added a test, that skips if 'pyOpenSSL' is not installed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1491: [BEAM-1070] Call from_p12_keyfile() with ...

Posted by aaltay <gi...@git.apache.org>.
Github user aaltay closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1491


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---