You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/10/28 02:04:21 UTC
[GitHub] incubator-beam pull request #1215: [BEAM-498] Add static factory method for ...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1215
[BEAM-498] Add static factory method for DoFnInfo
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This provides a clearer migration path away from deprecated code paths than constructor overloads which can only be selected by upcasting, etc.
R: @lukecwik
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam DoFnInfo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1215
----
commit be430676ec6e649973ff8c38ad28c6121270a171
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-10-28T02:01:03Z
Add static factory methods for DoFnInfo
This provides a clearer migration path away from deprecated
code paths than constructor overloads which can only be selected
by upcasting, etc.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1215: [BEAM-498] Add static factory method for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---