You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2021/03/10 06:15:02 UTC

[incubator-nuttx] branch master updated (9b7d0a0 -> 2c753be)

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


    from 9b7d0a0  Add BMP180 sensor support.
     new 06a81db  boards: spresense: Update rndis_smp/defconfig
     new 2c753be  Revert "arch: cxd56xx: Fix cxd56_usbdev.c for SMP"

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 arch/arm/src/cxd56xx/cxd56_usbdev.c                      | 16 ----------------
 boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig |  5 ++++-
 2 files changed, 4 insertions(+), 17 deletions(-)


[incubator-nuttx] 01/02: boards: spresense: Update rndis_smp/defconfig

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 06a81db203d209419f3815f38317798d6498ab31
Author: Masayuki Ishikawa <ma...@gmail.com>
AuthorDate: Wed Mar 10 11:34:03 2021 +0900

    boards: spresense: Update rndis_smp/defconfig
    
    Summary:
    - This commit updates rndis_smp/defconfig
    - Adjust stack size to avoid hardfault
    - Remove CONFIG_NET_TCP_WRITE_BUFFERS temporarily to avoid
      unstable behaviors with nxplayer + telnet
    
    Impact:
    - spresense:rndis_smp only
    
    Testing:
    - Tested with nxplayer, telnet
    
    Signed-off-by: Masayuki Ishikawa <Ma...@jp.sony.com>
---
 boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig b/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig
index dcadf51..ea2776f 100644
--- a/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig
+++ b/boards/arm/cxd56xx/spresense/configs/rndis_smp/defconfig
@@ -14,6 +14,7 @@ CONFIG_ARCH_BOARD="spresense"
 CONFIG_ARCH_BOARD_SPRESENSE=y
 CONFIG_ARCH_CHIP="cxd56xx"
 CONFIG_ARCH_CHIP_CXD56XX=y
+CONFIG_ARCH_INTERRUPTSTACK=2048
 CONFIG_ARCH_STACKDUMP=y
 CONFIG_ARMV7M_USEBASEPRI=y
 CONFIG_AUDIO=y
@@ -106,7 +107,6 @@ CONFIG_NET_ROUTE=y
 CONFIG_NET_STATISTICS=y
 CONFIG_NET_TCP=y
 CONFIG_NET_TCPBACKLOG=y
-CONFIG_NET_TCP_WRITE_BUFFERS=y
 CONFIG_NET_UDP=y
 CONFIG_NET_UDP_BINDTODEVICE=y
 CONFIG_NFILE_DESCRIPTORS=8
@@ -118,6 +118,7 @@ CONFIG_NSH_READLINE=y
 CONFIG_NSH_TELNETD_CLIENTSTACKSIZE=3072
 CONFIG_NXPLAYER_HTTP_STREAMING_SUPPORT=y
 CONFIG_NXPLAYER_MAINTHREAD_STACKSIZE=3072
+CONFIG_NXPLAYER_PLAYTHREAD_STACKSIZE=3072
 CONFIG_PATH_INITIAL="/mnt/sd0/bin"
 CONFIG_PREALLOC_MQ_MSGS=64
 CONFIG_PREALLOC_TIMERS=4
@@ -135,6 +136,7 @@ CONFIG_SMARTFS_ALIGNED_ACCESS=y
 CONFIG_SMARTFS_MAXNAMLEN=30
 CONFIG_SMARTFS_MULTI_ROOT_DIRS=y
 CONFIG_SMP=y
+CONFIG_SMP_IDLETHREAD_STACKSIZE=1024
 CONFIG_SMP_NCPUS=2
 CONFIG_SPI=y
 CONFIG_SPRESENSE_EXTENSION=y
@@ -162,4 +164,5 @@ CONFIG_UART1_SERIAL_CONSOLE=y
 CONFIG_USBDEV=y
 CONFIG_USBDEV_DMA=y
 CONFIG_USBDEV_DUALSPEED=y
+CONFIG_USERMAIN_STACKSIZE=3072
 CONFIG_USER_ENTRYPOINT="spresense_main"


[incubator-nuttx] 02/02: Revert "arch: cxd56xx: Fix cxd56_usbdev.c for SMP"

Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 2c753be0dfc1cdaf24caff7196519f9e40263485
Author: Masayuki Ishikawa <ma...@gmail.com>
AuthorDate: Wed Mar 10 11:41:15 2021 +0900

    Revert "arch: cxd56xx: Fix cxd56_usbdev.c for SMP"
    
    Summary:
    - The original commit was added to avoid hardfault but the
      root cause was the stack corruption which has been fixed by
      the previous commit. So let me revert the original commit.
    
    Impact:
    - SMP only
    
    Testing:
    - spresense:rndis_smp with nxplayer + telnet
    
    This reverts commit 197187d8267e1c72dd230bc46390192cf47270c3.
    
    Signed-off-by: Masayuki Ishikawa <Ma...@jp.sony.com>
---
 arch/arm/src/cxd56xx/cxd56_usbdev.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/arch/arm/src/cxd56xx/cxd56_usbdev.c b/arch/arm/src/cxd56xx/cxd56_usbdev.c
index a0e70fd..8a96636 100644
--- a/arch/arm/src/cxd56xx/cxd56_usbdev.c
+++ b/arch/arm/src/cxd56xx/cxd56_usbdev.c
@@ -1540,10 +1540,6 @@ static int cxd56_epinterrupt(int irq, FAR void *context)
   uint16_t len;
   int n;
 
-#ifdef CONFIG_SMP
-  irqstate_t flags = enter_critical_section();
-#endif
-
   eps = getreg32(CXD56_USB_DEV_EP_INTR);
     {
       for (n = 0; n < CXD56_NENDPOINTS; n++)
@@ -1817,10 +1813,6 @@ static int cxd56_epinterrupt(int irq, FAR void *context)
         }
     }
 
-#ifdef CONFIG_SMP
-  leave_critical_section(flags);
-#endif
-
   return OK;
 }
 
@@ -2593,10 +2585,6 @@ static int cxd56_epstall(FAR struct usbdev_ep_s *ep, bool resume)
   uint32_t ctrl;
   uint32_t addr;
 
-#ifdef CONFIG_SMP
-  irqstate_t flags = enter_critical_section();
-#endif
-
   addr = USB_ISEPIN(ep->eplog) ? CXD56_USB_IN_EP_CONTROL(privep->epphy)
                                : CXD56_USB_OUT_EP_CONTROL(privep->epphy);
 
@@ -2615,10 +2603,6 @@ static int cxd56_epstall(FAR struct usbdev_ep_s *ep, bool resume)
       privep->stalled = 1;
     }
 
-#ifdef CONFIG_SMP
-  leave_critical_section(flags);
-#endif
-
   return OK;
 }