You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/22 17:09:41 UTC
[GitHub] [spark] holdenk opened a new pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
holdenk opened a new pull request #28614:
URL: https://github.com/apache/spark/pull/28614
### What changes were proposed in this pull request?
Increase the timeout and register the listener earlier to avoid any race condition of the job starting before the listener is registered.
### Why are the changes needed?
The test is currently semi-flaky.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I'm currently running the following bash script on my dev machine to verify the flakiness decreases. It has gotten to 356 iterations without any test failures so I believe issue is fixed.
```
set -ex
./build/sbt clean compile package
((failures=0))
for (( i=0;i<1000;++i )); do
echo "Run $i"
((failed=0))
./build/sbt "core/testOnly org.apache.spark.scheduler.WorkerDecommissionSuite" || ((failed=1))
echo "Resulted in $failed"
((failures=failures+failed))
echo "Current status is failures: $failures out of $i runs"
done
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632902929
I intend to merge by 5pm pacific if no one has suggestions as it is a test-only improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632894527
**[Test build #123012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123012/testReport)** for PR 28614 at commit [`b5e83de`](https://github.com/apache/spark/commit/b5e83dea3ed263d15c7d31969cfac2f345575a71).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #28614:
URL: https://github.com/apache/spark/pull/28614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632812750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632811137
cc @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632812750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632812251
**[Test build #123012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123012/testReport)** for PR 28614 at commit [`b5e83de`](https://github.com/apache/spark/commit/b5e83dea3ed263d15c7d31969cfac2f345575a71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632961876
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632895018
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123012/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632895018
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123012/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-633791726
+1, late LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28614:
URL: https://github.com/apache/spark/pull/28614#issuecomment-632812251
**[Test build #123012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123012/testReport)** for PR 28614 at commit [`b5e83de`](https://github.com/apache/spark/commit/b5e83dea3ed263d15c7d31969cfac2f345575a71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org