You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/09/20 15:56:24 UTC
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4477
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND
......................................................................
[twitter-demo] use AUTO_FLUSH_BACKGROUND
Changed the twitter demo application to use sessions in
AUTO_FLUSH_BACKGROUND instead of sessions in MANUAL_FLUSH mode.
Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 55 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/1
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
Patch Set 5:
> have you tried to run the demo app now?
Yes, I ran those before submitting the previous patch on MacOS X. I tried both the demo:
./bin/ingest_firehose -twitter_rpc_master_address=localhost:8765 -twitter_firehose_source=file -twitter_firehose_file=./bin/example-tweets.txt
and the tests:
./bin/parser-test
./bin/oauth-test
What else do you think I should do for better verification?
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
Patch Set 3:
did you test this manually? I'm not sure whether jenkins even builds this (needs oauth) and pretty sure there are no tests.
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
[twitter-demo] use AUTO_FLUSH_BACKGROUND session
Changed the twitter demo application to use AUTO_FLUSH_BACKGROUND
flush mode instead of MANUAL_FLUSH mode.
Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Reviewed-on: http://gerrit.cloudera.org:8080/4477
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 61 insertions(+), 115 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
Patch Set 5:
nah, that all I wanted. thanks
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
Patch Set 5:
have you tried to run the demo app now?
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4477
to look at the new patch set (#3).
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
[twitter-demo] use AUTO_FLUSH_BACKGROUND session
Changed the twitter demo application to use AUTO_FLUSH_BACKGROUND
flush mode instead of MANUAL_FLUSH mode.
Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 58 insertions(+), 114 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/3
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
Patch Set 6:
> nah, that all I wanted. thanks
OK, thanks. Meanwhile, I'll try to run those on Linux as well (I have a special virtual machine for that).
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4477
to look at the new patch set (#2).
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND
......................................................................
[twitter-demo] use AUTO_FLUSH_BACKGROUND
Changed the twitter demo application to use sessions in
AUTO_FLUSH_BACKGROUND instead of sessions in MANUAL_FLUSH mode.
Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 57 insertions(+), 113 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/2
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
Patch Set 3:
> did you test this manually? I'm not sure whether jenkins even
> builds this (needs oauth) and pretty sure there are no tests.
Yes, sure -- I built it on MacOS X (installed liboauth from ports). It worked for me.
Or you mentioned running that demo app? I haven't tried to run that. Will try to do that.
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4477
to look at the new patch set (#5).
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
[twitter-demo] use AUTO_FLUSH_BACKGROUND session
Changed the twitter demo application to use AUTO_FLUSH_BACKGROUND
flush mode instead of MANUAL_FLUSH mode.
Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 61 insertions(+), 115 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/5
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [twitter-demo] use AUTO FLUSH BACKGROUND session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4477
to look at the new patch set (#4).
Change subject: [twitter-demo] use AUTO_FLUSH_BACKGROUND session
......................................................................
[twitter-demo] use AUTO_FLUSH_BACKGROUND session
Changed the twitter demo application to use AUTO_FLUSH_BACKGROUND
flush mode instead of MANUAL_FLUSH mode.
Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
---
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
3 files changed, 59 insertions(+), 115 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4477/4
--
To view, visit http://gerrit.cloudera.org:8080/4477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I497c1265df132fc8ea4e635475d0d669eca21646
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot