You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Superskyyy (via GitHub)" <gi...@apache.org> on 2024/05/25 07:42:55 UTC
[PR] Fix aggregation and value type [skywalking-banyandb-java-client]
Superskyyy opened a new pull request, #57:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/57
1. SumBy uses wrong aggregation method, was COUNT should be SUM
2. Missing the float tag type field when doing write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix aggregation and value type [skywalking-banyandb-java-client]
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #57:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/57#issuecomment-2131111665
Found these during internal testing. Not sure if fix is correct, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix aggregation and value type [skywalking-banyandb-java-client]
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 merged PR #57:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix aggregation and value type [skywalking-banyandb-java-client]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #57:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/57#issuecomment-2131128574
I think server side doesn't support float yet, too. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix aggregation and value type [skywalking-banyandb-java-client]
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #57:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/57#issuecomment-2131154425
> I think server side doesn't support float yet, too. Right?
https://github.com/apache/skywalking-banyandb/pull/240 Looks like it's there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix aggregation and value type [skywalking-banyandb-java-client]
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #57:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/57#issuecomment-2131147844
> where do we need float？
To record some fractional data like memory usage. Is this currently not supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix aggregation and value type [skywalking-banyandb-java-client]
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #57:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/57#issuecomment-2131115754
where do we need float？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org