You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/12/14 22:27:33 UTC
Review Request 64626: Prototype: Added
LIBPROCESS_LOCAL_MESSAGE_PASSING option.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64626/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
The new option allows to disable local message passing when messages are
sent between UPIDs in the same OS process. Enabled by default.
Diffs
-----
3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf
Diff: https://reviews.apache.org/r/64626/diff/1/
Testing
-------
Ran `make check` and `make check LIBPROCESS_LOCAL_MESSAGE_PASSING=0` in libprocess.
Ran `make check` in Mesos. Disabled local message passing breaks Mesos tests that use the replicated log, because it seemingly relies on "immediate" local message delivery (see [CoordinatorProcess::checkLearnPhase()](https://github.com/apache/mesos/blob/784b7f599f8ad8350fc7d6703a4b584301b23edc/src/log/coordinator.cpp#L396)).
Thanks,
Ilya Pronin
Re: Review Request 64626: Prototype: Added
LIBPROCESS_LOCAL_MESSAGE_PASSING option.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64626/#review193858
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64626']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64626
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64626/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2314 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2336 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2359 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2381 ms total)
[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (297654 ms total)
[ PASSED ] 825 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending
10 FAILED TESTS
YOU HAVE 205 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64626/logs/mesos-tests-stderr.log):
```
I1214 23:17:03.704596 5264 master.cpp:10160] Updating the state of task f6f71cd1-d2bb-484e-9bf2-0704c0235138 of framework d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-0000 (latest state: TASK_KILLED, status updateI1214 23:17:03.045591 6576 exec.cpp:162] Version: 1.5.0
I1214 23:17:03.068591 4756 exec.cpp:237] Executor registered on agent d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-S0
I1214 23:17:03.071593 5052 executor.cpp:171] Received SUBSCRIBED event
I1214 23:17:03.075590 5052 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1214 23:17:03.075590 5052 executor.cpp:171] Received LAUNCH event
I1214 23:17:03.080590 5052 executor.cpp:638] Starting task f6f71cd1-d2bb-484e-9bf2-0704c0235138
I1214 23:17:03.152612 5052 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1214 23:17:03.678596 5052 executor.cpp:651] Forked command at 4428
I1214 23:17:03.705595 924 exec.cpp:435] Executor asked to shutdown
I1214 23:17:03.706595 6692 executor.cpp:171] Received SHUTDOWN event
I1214 23:17:03.706595 6692 executor.cpp:748] Shutting down
I1214 23:17:03.706595 6692 executor.cpp:855] Sending SIGTERM to process tree at pid 4 state: TASK_KILLED)
I1214 23:17:03.704596 1684 slave.cpp:3401] Shutting down framework d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-0000
I1214 23:17:03.704596 1684 slave.cpp:6109] Shutting down executor 'f6f71cd1-d2bb-484e-9bf2-0704c0235138' of framework d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-0000 at executor(1)@10.3.1.5:51691
I1214 23:17:03.705595 1684 slave.cpp:909] Agent terminating
W1214 23:17:03.705595 1684 slave.cpp:3397] Ignoring shutdown framework d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-0000 because it is terminating
I1214 23:17:03.706595 5264 master.cpp:10266] Removing task f6f71cd1-d2bb-484e-9bf2-0704c0235138 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-0000 on agent d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-S0 at slave(327)@10.3.1.5:51670 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 23:17:03.708595 5264 master.cpp:1305] Agent d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-S0 at slave(327)@10.3.1.5:51670 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1214 23:17:03.708595 8012 containerizer.cpp:2337] Destroying container 70c8b3c6-7b4e-4052-902d-5b9e034f5031 in RUNNING state
I1214 23:17:03.709595 5264 master.cpp:3364] Disconnecting agent d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-S0 at slave(327)@10.3.1.5:51670 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 23:17:03.709595 8012 containerizer.cpp:2939] Transitioning the state of container 70c8b3c6-7b4e-4052-902d-5b9e034f5031 from RUNNING to DESTROYING
I1214 23:17:03.709595 5264 master.cpp:3383] Deactivating agent d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-S0 at slave(327)@10.3.1.5:51670 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 23:17:03.709595 832 hierarchical.cpp:344] Removed framework d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-0000
I1214 23:17:03.709595 8012 launcher.cpp:156] Asked to destroy container 70c8b3c6-7b4e-4052-902d-5b9e034f5031
I1214 23:17:03.709595 832 hierarchical.cpp:766] Agent d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-S0 deactivated
I1214 23:17:03.802798 5156 containerizer.cpp:2788] Container 70c8b3c6-7b4e-4052-902d-5b9e034f5031 has exited
I1214 23:17:03.830798 2260 master.cpp:1147] Master terminating
I1214 23:17:03.832823 5264 hierarchical.cpp:609] Removed agent d4f0b8b2-ec78-46cb-b61a-b7ed31d3e7ee-S0
I1214 23:17:04.150825 2084 process.cpp:897] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 14, 2017, 10:33 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64626/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 10:33 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new option allows to disable local message passing when messages are
> sent between UPIDs in the same OS process. Enabled by default.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf
>
>
> Diff: https://reviews.apache.org/r/64626/diff/1/
>
>
> Testing
> -------
>
> Ran `make check` and `make check LIBPROCESS_LOCAL_MESSAGE_PASSING=0` in libprocess.
> Ran `make check` in Mesos. Disabled local message passing breaks Mesos tests that use the replicated log, because it seemingly relies on "immediate" local message delivery (see [CoordinatorProcess::checkLearnPhase()](https://github.com/apache/mesos/blob/784b7f599f8ad8350fc7d6703a4b584301b23edc/src/log/coordinator.cpp#L396)).
> Manually verified that messages are going through the network with `tcpdump`.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 64626: Prototype: Added
LIBPROCESS_LOCAL_MESSAGE_PASSING option.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64626/#review193855
-----------------------------------------------------------
Hm.. perhaps we need a pattern based approach? From the existing benchmarks, we usually want specific messages only to go through http, for example messages between master <-> scheduler.
- Benjamin Mahler
On Dec. 14, 2017, 10:33 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64626/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 10:33 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new option allows to disable local message passing when messages are
> sent between UPIDs in the same OS process. Enabled by default.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf
>
>
> Diff: https://reviews.apache.org/r/64626/diff/1/
>
>
> Testing
> -------
>
> Ran `make check` and `make check LIBPROCESS_LOCAL_MESSAGE_PASSING=0` in libprocess.
> Ran `make check` in Mesos. Disabled local message passing breaks Mesos tests that use the replicated log, because it seemingly relies on "immediate" local message delivery (see [CoordinatorProcess::checkLearnPhase()](https://github.com/apache/mesos/blob/784b7f599f8ad8350fc7d6703a4b584301b23edc/src/log/coordinator.cpp#L396)).
> Manually verified that messages are going through the network with `tcpdump`.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 64626: Prototype: Added
LIBPROCESS_LOCAL_MESSAGE_PASSING option.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64626/
-----------------------------------------------------------
(Updated Dec. 14, 2017, 2:33 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Updated testing description.
Repository: mesos
Description
-------
The new option allows to disable local message passing when messages are
sent between UPIDs in the same OS process. Enabled by default.
Diffs
-----
3rdparty/libprocess/src/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf
Diff: https://reviews.apache.org/r/64626/diff/1/
Testing (updated)
-------
Ran `make check` and `make check LIBPROCESS_LOCAL_MESSAGE_PASSING=0` in libprocess.
Ran `make check` in Mesos. Disabled local message passing breaks Mesos tests that use the replicated log, because it seemingly relies on "immediate" local message delivery (see [CoordinatorProcess::checkLearnPhase()](https://github.com/apache/mesos/blob/784b7f599f8ad8350fc7d6703a4b584301b23edc/src/log/coordinator.cpp#L396)).
Manually verified that messages are going through the network with `tcpdump`.
Thanks,
Ilya Pronin