[jira] [Commented] (LUCENE-8466) FrozenBufferedUpdates#apply*Deletes is incorrect when index sorting is enabled

["Jim Ferenczi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593610#comment-16593610 ] 

Jim Ferenczi commented on LUCENE-8466:
--------------------------------------

Here is a patch that fixes delete by query. It seems that the issue only affects FrozenBufferedUpdates#applyQueryDeletes and by extension any usage of IndexWriter#deleteDocuments(Query... queries).  Other types of deletions/updates (by term or doc values update) are not affected and work as expected with index sorting.

> FrozenBufferedUpdates#apply*Deletes is incorrect when index sorting is enabled
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-8466
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8466
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Priority: Critical
>         Attachments: LUCENE-8466.patch
>
>
> This was reported by Vish Ramachandran at https://markmail.org/message/w27h7n2isb5eogos. When deleting by term or query, we record the term/query that is deleted and the current max doc id. Deletes are later applied on flush by FrozenBufferedUpdates#apply*Deletes. Unfortunately, this doesn't work when index sorting is enabled since documents are renumbered between the time that the current max doc id is computed and the time that deletes are applied.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org