You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2021/03/15 01:06:13 UTC

[impala] 02/02: IMPALA-10559: Fix flakiness in TestScratchLimit.

This is an automated email from the ASF dual-hosted git repository.

stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 37ec96e72af782900760e24eb520dd7904c3d632
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Sat Mar 13 10:35:05 2021 -0800

    IMPALA-10559: Fix flakiness in TestScratchLimit.
    
    TestScratchLimit has been flaky in ubuntu-16.04-dockerised-tests
    environment since results spooling is enabled by default in IMPALA-9856.
    A combination of result spooling, sort query, and low buffer_pool_limit
    in TestScratchLimit::test_with_unlimited_scratch_limit seems to reveal a
    memory reservation bug in BufferedTutpleStream. This patch disables
    result spooling for tests under TestScratchLimit until the underlying
    bug is found. We will investigate the bug in a separate JIRA.
    
    Testing:
    - Disable result spooling in all tests of TestScratchLimit before
      IMPALA-9856 gets in.
    - Run and pass TestScratchLimit locally.
    
    Change-Id: I68736d6bfb0001423fd138000670ac60b2117fbe
    Reviewed-on: http://gerrit.cloudera.org:8080/17182
    Reviewed-by: Quanlong Huang <hu...@gmail.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_scratch_limit.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/query_test/test_scratch_limit.py b/tests/query_test/test_scratch_limit.py
index 8779cd3..07f34da 100644
--- a/tests/query_test/test_scratch_limit.py
+++ b/tests/query_test/test_scratch_limit.py
@@ -71,6 +71,7 @@ class TestScratchLimit(ImpalaTestSuite):
     exec_option = vector.get_value('exec_option')
     exec_option['buffer_pool_limit'] = self.buffer_pool_limit
     exec_option['scratch_limit'] = '500m'
+    exec_option['spool_query_results'] = '0'
     self.execute_query_expect_success(self.client, self.spilling_sort_query, exec_option)
 
   def test_with_low_scratch_limit(self, vector):
@@ -81,6 +82,7 @@ class TestScratchLimit(ImpalaTestSuite):
     exec_option = vector.get_value('exec_option')
     exec_option['buffer_pool_limit'] = self.buffer_pool_limit
     exec_option['scratch_limit'] = '24m'
+    exec_option['spool_query_results'] = '0'
     expected_error = 'Scratch space limit of %s bytes exceeded'
     scratch_limit_in_bytes = 24 * 1024 * 1024
     try:
@@ -97,6 +99,7 @@ class TestScratchLimit(ImpalaTestSuite):
     exec_option = vector.get_value('exec_option')
     exec_option['buffer_pool_limit'] = self.buffer_pool_limit
     exec_option['scratch_limit'] = '0'
+    exec_option['spool_query_results'] = '0'
     for query in self.spilling_queries:
       self.execute_query_expect_failure(query, exec_option)
 
@@ -107,6 +110,7 @@ class TestScratchLimit(ImpalaTestSuite):
     exec_option = vector.get_value('exec_option')
     exec_option['buffer_pool_limit'] = self.buffer_pool_limit
     exec_option['scratch_limit'] = '-1'
+    exec_option['spool_query_results'] = '0'
     self.execute_query_expect_success(self.client, self.spilling_sort_query, exec_option)
 
   def test_without_specifying_scratch_limit(self, vector):
@@ -115,6 +119,7 @@ class TestScratchLimit(ImpalaTestSuite):
     """
     exec_option = vector.get_value('exec_option')
     exec_option['buffer_pool_limit'] = self.buffer_pool_limit
+    exec_option['spool_query_results'] = '0'
     self.execute_query_expect_success(self.client, self.spilling_sort_query, exec_option)
 
   def test_with_zero_scratch_limit_no_memory_limit(self, vector):
@@ -124,6 +129,7 @@ class TestScratchLimit(ImpalaTestSuite):
     """
     exec_option = vector.get_value('exec_option')
     exec_option['scratch_limit'] = '0'
+    exec_option['spool_query_results'] = '0'
     for query in self.spilling_queries:
       self.execute_query_expect_success(self.client, query, exec_option)