You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bb...@apache.org on 2019/09/18 10:52:44 UTC

[mesos] 07/09: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

This is an automated email from the ASF dual-hosted git repository.

bbannier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git

commit 3478e40c656160b8f08e0ad8c154289417bb6aaa
Author: Benjamin Bannier <bb...@apache.org>
AuthorDate: Wed Sep 18 11:37:17 2019 +0200

    Revert "Updated cpplint.py to be less verbose when there is no linting issue."
    
    This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.
    
    This patch was necessary when we were running cpplint via
    `support/mesos-style.py` to prevent it from cluttering up the hook
    output. When running under pre-commit linter output is not shown if no
    errors occur so we can undo our change to stay closer to upstream.
    
    Review: https://reviews.apache.org/r/71207/
---
 support/cpplint.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/support/cpplint.py b/support/cpplint.py
index 66ec8b3..5671873 100755
--- a/support/cpplint.py
+++ b/support/cpplint.py
@@ -978,8 +978,7 @@ class _CppLintState(object):
     for category, count in iteritems(self.errors_by_category):
       sys.stderr.write('Category \'%s\' errors found: %d\n' %
                        (category, count))
-    if self.error_count > 0:
-      sys.stdout.write('Total errors found: %d\n' % self.error_count)
+    sys.stdout.write('Total errors found: %d\n' % self.error_count)
 
 _cpplint_state = _CppLintState()