You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/04/12 09:14:28 UTC

Review Request 58381: Added a Table abstraction to the new CLI.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58381/
-----------------------------------------------------------

Review request for mesos and Joseph Wu.


Bugs: MESOS-7282
    https://issues.apache.org/jira/browse/MESOS-7282


Repository: mesos


Description
-------

This will be used by future plugins.


Diffs
-----

  src/cli_new/lib/cli/util.py ace07fb64e130e2f02d4ab5607ee1a84161ef88b 


Diff: https://reviews.apache.org/r/58381/diff/1/


Testing
-------

Tested manually, PEP8 and Pylint used to make sure that the code style is correct.


Thanks,

Armand Grillet

Re: Review Request 58381: Added a Table abstraction to the new CLI.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58381/#review171974
-----------------------------------------------------------


Ship it!




LGTM.

As we discussed offline, since this code was originally posted here: https://reviews.apache.org/r/52948/
the commit will be attributed according to Haris Cloudhary, from whom Kevin obtained the code.

- Joseph Wu


On April 12, 2017, 2:14 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58381/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 2:14 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7282
>     https://issues.apache.org/jira/browse/MESOS-7282
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used by future plugins.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/lib/cli/util.py ace07fb64e130e2f02d4ab5607ee1a84161ef88b 
> 
> 
> Diff: https://reviews.apache.org/r/58381/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>