You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by bi...@apache.org on 2017/01/11 07:53:19 UTC
[2/5] kylin git commit: rollback ITEM_COUNT to INT type
rollback ITEM_COUNT to INT type
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/3a3ee3c1
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/3a3ee3c1
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/3a3ee3c1
Branch: refs/heads/yang22-hbase1.x
Commit: 3a3ee3c1cae56d4fed6948d64de23178c1a2cd1e
Parents: fb42404
Author: Yang Li <li...@apache.org>
Authored: Wed Jan 11 07:15:24 2017 +0800
Committer: Yang Li <li...@apache.org>
Committed: Wed Jan 11 07:15:24 2017 +0800
----------------------------------------------------------------------
.../localmeta/table/DEFAULT.TEST_KYLIN_FACT.json | 2 +-
.../test/java/org/apache/kylin/query/HackedDbUnitAssert.java | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/3a3ee3c1/examples/test_case_data/localmeta/table/DEFAULT.TEST_KYLIN_FACT.json
----------------------------------------------------------------------
diff --git a/examples/test_case_data/localmeta/table/DEFAULT.TEST_KYLIN_FACT.json b/examples/test_case_data/localmeta/table/DEFAULT.TEST_KYLIN_FACT.json
index 53dc96b..fdfb322 100644
--- a/examples/test_case_data/localmeta/table/DEFAULT.TEST_KYLIN_FACT.json
+++ b/examples/test_case_data/localmeta/table/DEFAULT.TEST_KYLIN_FACT.json
@@ -33,7 +33,7 @@
}, {
"id" : "8",
"name" : "ITEM_COUNT",
- "datatype" : "bigint"
+ "datatype" : "int"
}, {
"id" : "9",
"name" : "SELLER_ID",
http://git-wip-us.apache.org/repos/asf/kylin/blob/3a3ee3c1/kylin-it/src/test/java/org/apache/kylin/query/HackedDbUnitAssert.java
----------------------------------------------------------------------
diff --git a/kylin-it/src/test/java/org/apache/kylin/query/HackedDbUnitAssert.java b/kylin-it/src/test/java/org/apache/kylin/query/HackedDbUnitAssert.java
index c295430..338f698 100644
--- a/kylin-it/src/test/java/org/apache/kylin/query/HackedDbUnitAssert.java
+++ b/kylin-it/src/test/java/org/apache/kylin/query/HackedDbUnitAssert.java
@@ -70,11 +70,8 @@ public class HackedDbUnitAssert extends DbUnitAssert {
// throw error;
// }
- // if both tables are empty, it is not necessary to compare columns, as
- // such
- // comparison
- // can fail if column metadata is different (which could occurs when
- // comparing empty tables)
+ // if both tables are empty, it is not necessary to compare columns, as such comparison
+ // can fail if column metadata is different (which could occurs when comparing empty tables)
if (expectedTable.getRowCount() == 0 && actualTable.getRowCount() == 0) {
logger.debug("Tables are empty, hence equals.");
return;