[GitHub] activemq-artemis issue #1607: ARTEMIS-1478 - ActiveMQ Artemis to Kafka Bridg...

[gemmellr <gi...@git.apache.org>]

Github user gemmellr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1607
  
    Skimming the code quickly, I had to do a double take on a couple of occasions, and had some related observations.
    
    There looked to be extensive use of implementation detail classes from the Qpid JMS client here. This seems inherently fragile as these classes are not intended for direct application usage in this fashion, and are entirely subject to change from release to release. Related, there also appeared to be some new class definitions within the org.apache.qpid namespace, which doesn't seem nice either.
    
    Separately, I don't really understand why they would need/want to be used this way anyway. Presumably the Kafka message content in that case is an encoded AMQP message, so anything that can decode AMQP message would work, e.g the proton based bits also included. Its not clear to me why it woudl be desirable to involve JMS at all. Regardless, if you actually wanted a JMS message, why not consume it from the broker using the JMS client to begin with?
    
    The logo feels like something only a standalone component would have.


---