You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "kbuci (via GitHub)" <gi...@apache.org> on 2026/02/11 02:41:44 UTC
[PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
kbuci opened a new pull request, #18172:
URL: https://github.com/apache/hudi/pull/18172
### Describe the issue this Pull Request addresses
When the single clustering group config is **disabled** (`hoodie.clustering.plan.strategy.single.group.clustering.enabled=false`), the clustering plan strategy could still create clustering groups where both the number of input files and output files was 1. Clustering one file into one file has no benefit and wastes resources. This fix ensures that when single-group clustering is disabled, such no-op groups are not created.
### Summary and Changelog
**Summary:** When single-group clustering is disabled, clustering no longer schedules groups that would cluster one file into one file. All other clustering behavior is unchanged.
**Changelog:**
- **PartitionAwareClusteringPlanStrategy**: If `isSingleGroupClusteringEnabled` is enabled, then clustering groups should be skipped if # of input/output file slices are the same
### Impact
- **Public API:** None.
- **Performance:** Reduces unnecessary clustering work and scheduling for single-file partitions when the config is disabled.
### Risk Level
**Low.** The change only affects the case where single-group clustering is disabled and a group would have 1 input and 1 output; all other behavior is unchanged. Logic is covered by the new unit test `testRemaningFileInPartitionNotClustered()`.
### Documentation Update
None. This is a behavioral fix for an existing config; no new config or default change.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027624213
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.84%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (22aa1fa) and HEAD (a55b2fd). Click for more details.
>
> <details><summary>HEAD has 11 uploads less than BASE</summary>
>
>| Flag | BASE (22aa1fa) | HEAD (a55b2fd) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.30% 43.84% -13.47%
+ Complexity 18627 13700 -4927
=============================================
Files 1955 1938 -17
Lines 106916 104507 -2409
Branches 13225 12626 -599
=============================================
- Hits 61271 45816 -15455
- Misses 39854 53449 +13595
+ Partials 5791 5242 -549
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.54% <53.84%> (-13.94%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.31% <53.84%> (-12.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (-26.64%)` | :arrow_down: |
... and [804 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027298402
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
}, {
"hash" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468",
"triggerID" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"triggerType" : "PUSH"
}, {
"hash" : "a55b2fd22ec98338f874a612df2024d85bcff6e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a55b2fd22ec98338f874a612df2024d85bcff6e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5f7228c2411862f1c71c25014621813738b7d9a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468)
* a55b2fd22ec98338f874a612df2024d85bcff6e6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3888331419
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6380dc82e7b86451539c77ac044fd5b581d7555a Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922)
* 0823b4923202e68e8398143352001b8a880c645d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3992642573
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.24%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.31% 57.24% -0.07%
+ Complexity 18602 18600 -2
============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
============================================
- Hits 61085 61083 -2
- Misses 39734 39854 +120
+ Partials 5761 5760 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.41% <53.84%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `90.83% <53.84%> (-3.86%)` | :arrow_down: |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3881809656
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6380dc82e7b86451539c77ac044fd5b581d7555a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988101817
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.24%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.31% 57.24% -0.08%
+ Complexity 18602 18600 -2
============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
============================================
- Hits 61085 61075 -10
- Misses 39734 39860 +126
- Partials 5761 5762 +1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.37% <53.84%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `90.83% <53.84%> (-3.86%)` | :arrow_down: |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3987501836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0823b4923202e68e8398143352001b8a880c645d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969)
* 9efbb40005d86e090aec4b61c8985c1bf0b3b89e Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008721870
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.37%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 45.25% 43.37% -1.89%
- Complexity 8412 13859 +5447
============================================
Files 1186 1954 +768
Lines 60793 106830 +46037
Branches 6478 13198 +6720
============================================
+ Hits 27512 46336 +18824
- Misses 30296 55158 +24862
- Partials 2985 5336 +2351
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.02% <53.84%> (?)` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (+6.12%)` | :arrow_up: |
... and [1151 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008715019
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.65%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 45.25% 39.65% -5.61%
- Complexity 8412 12620 +4208
============================================
Files 1186 1954 +768
Lines 60793 106830 +46037
Branches 6478 13198 +6720
============================================
+ Hits 27512 42363 +14851
- Misses 30296 59384 +29088
- Partials 2985 5083 +2098
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `68.29% <53.84%> (+4.49%)` | :arrow_up: |
... and [1051 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010446918
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.20%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (6e0d786) and HEAD (c5f7228). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (6e0d786) | HEAD (c5f7228) |
>|------|------|------|
>|spark-scala-tests|6|0|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.24% 45.20% -12.05%
+ Complexity 18617 8398 -10219
=============================================
Files 1954 1186 -768
Lines 106823 60800 -46023
Branches 13198 6478 -6720
=============================================
- Hits 61152 27484 -33668
+ Misses 39906 30336 -9570
+ Partials 5765 2980 -2785
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `61.78% <53.84%> (-34.77%)` | :arrow_down: |
... and [1385 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010629672
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.45%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (6e0d786) and HEAD (c5f7228). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (6e0d786) | HEAD (c5f7228) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.24% 43.45% -13.79%
+ Complexity 18617 13883 -4734
=============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
=============================================
- Hits 61152 46426 -14726
- Misses 39906 55086 +15180
+ Partials 5765 5318 -447
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.20% <53.84%> (-14.22%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (-12.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (-26.64%)` | :arrow_down: |
... and [786 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3987488772
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0823b4923202e68e8398143352001b8a880c645d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969)
* 9efbb40005d86e090aec4b61c8985c1bf0b3b89e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010621235
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.40%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (6e0d786) and HEAD (c5f7228). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (6e0d786) | HEAD (c5f7228) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.24% 43.40% -13.84%
+ Complexity 18617 13870 -4747
=============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
=============================================
- Hits 61152 46372 -14780
- Misses 39906 55126 +15220
+ Partials 5765 5332 -433
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.56% <53.84%> (-13.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (-12.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (-26.64%)` | :arrow_down: |
... and [786 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010678359
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.76%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (6e0d786) and HEAD (c5f7228). Click for more details.
>
> <details><summary>HEAD has 8 uploads less than BASE</summary>
>
>| Flag | BASE (6e0d786) | HEAD (c5f7228) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.24% 48.76% -8.48%
+ Complexity 18617 15822 -2795
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
- Hits 61152 52098 -9054
- Misses 39906 49385 +9479
+ Partials 5765 5347 -418
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.13% <53.84%> (-4.29%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (-12.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `89.43% <53.84%> (-7.13%)` | :arrow_down: |
... and [539 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010683589
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.42%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.24% 55.42% -1.82%
+ Complexity 18617 17968 -649
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
- Hits 61152 59214 -1938
- Misses 39906 41774 +1868
- Partials 5765 5842 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.34% <53.84%> (-4.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.52% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [253 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027727613
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.54%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 55.54% -1.77%
+ Complexity 18627 18000 -627
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 59389 -1882
- Misses 39854 41672 +1818
- Partials 5791 5862 +71
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.50% <53.84%> (-3.97%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <53.84%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [232 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027686439
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.18%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 55.18% -2.12%
+ Complexity 18627 17898 -729
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 59009 -2262
- Misses 39854 42041 +2187
- Partials 5791 5873 +82
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.18% <53.84%> (-4.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <53.84%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [296 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027621905
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.80%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (22aa1fa) and HEAD (a55b2fd). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (22aa1fa) | HEAD (a55b2fd) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.30% 43.80% -13.51%
+ Complexity 18627 13690 -4937
=============================================
Files 1955 1938 -17
Lines 106916 104507 -2409
Branches 13225 12626 -599
=============================================
- Hits 61271 45780 -15491
- Misses 39854 53481 +13627
+ Partials 5791 5246 -545
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.00% <53.84%> (-13.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.31% <53.84%> (-12.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (-26.64%)` | :arrow_down: |
... and [804 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027624742
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.21%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (22aa1fa) and HEAD (a55b2fd). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (22aa1fa) | HEAD (a55b2fd) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.30% 43.21% -14.10%
+ Complexity 18627 13777 -4850
=============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
=============================================
- Hits 61271 46206 -15065
- Misses 39854 55435 +15581
+ Partials 5791 5282 -509
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <53.84%> (-14.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.31% <53.84%> (-12.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (-26.64%)` | :arrow_down: |
... and [789 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027312011
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
}, {
"hash" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468",
"triggerID" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"triggerType" : "PUSH"
}, {
"hash" : "a55b2fd22ec98338f874a612df2024d85bcff6e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12510",
"triggerID" : "a55b2fd22ec98338f874a612df2024d85bcff6e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5f7228c2411862f1c71c25014621813738b7d9a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468)
* a55b2fd22ec98338f874a612df2024d85bcff6e6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12510)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027700646
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.50%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 55.50% -1.81%
+ Complexity 18627 17985 -642
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 59344 -1927
- Misses 39854 41718 +1864
- Partials 5791 5861 +70
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.50% <53.84%> (-3.97%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <53.84%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [240 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027595299
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.21%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (22aa1fa) and HEAD (a55b2fd). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (22aa1fa) | HEAD (a55b2fd) |
>|------|------|------|
>|spark-scala-tests|6|0|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.30% 45.21% -12.10%
+ Complexity 18627 8411 -10216
=============================================
Files 1955 1186 -769
Lines 106916 60847 -46069
Branches 13225 6488 -6737
=============================================
- Hits 61271 27511 -33760
+ Misses 39854 30351 -9503
+ Partials 5791 2985 -2806
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `61.78% <53.84%> (-34.77%)` | :arrow_down: |
... and [1386 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008742073
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.46%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
+ Coverage 43.45% 55.46% +12.01%
- Complexity 13878 17986 +4108
=============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
=============================================
+ Hits 46416 59252 +12836
+ Misses 55088 41745 -13343
- Partials 5319 5833 +514
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.40% <53.84%> (+10.20%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (+12.38%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (+18.64%)` | :arrow_up: |
... and [690 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008739826
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.46%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
+ Coverage 43.45% 55.46% +12.01%
- Complexity 13878 17986 +4108
=============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
=============================================
+ Hits 46416 59252 +12836
+ Misses 55088 41745 -13343
- Partials 5319 5833 +514
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.40% <53.84%> (+10.20%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (+12.38%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (+18.64%)` | :arrow_up: |
... and [690 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010577162
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.41%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (6e0d786) and HEAD (c5f7228). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (6e0d786) | HEAD (c5f7228) |
>|------|------|------|
>|spark-scala-tests|6|1|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.24% 40.41% -16.83%
+ Complexity 18617 12288 -6329
=============================================
Files 1954 1920 -34
Lines 106823 102110 -4713
Branches 13198 12109 -1089
=============================================
- Hits 61152 41269 -19883
- Misses 39906 55995 +16089
+ Partials 5765 4846 -919
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.58% <53.84%> (-11.93%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `68.29% <53.84%> (-28.26%)` | :arrow_down: |
... and [888 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010580692
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.01%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (6e0d786) and HEAD (c5f7228). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (6e0d786) | HEAD (c5f7228) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.24% 40.01% -17.24%
+ Complexity 18617 12448 -6169
=============================================
Files 1954 1937 -17
Lines 106823 104414 -2409
Branches 13198 12599 -599
=============================================
- Hits 61152 41777 -19375
- Misses 39906 57654 +17748
+ Partials 5765 4983 -782
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <53.84%> (-12.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `68.29% <53.84%> (-28.26%)` | :arrow_down: |
... and [877 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988138651
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 283283b39d2b040ba24f96db8053425892ce32b0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010406598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
}, {
"hash" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468",
"triggerID" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a66c47010fbdd72cf12845e954d1ba36d15810d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458)
* c5f7228c2411862f1c71c25014621813738b7d9a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008628988
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`master@4499b0b`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=========================================
Coverage ? 45.24%
Complexity ? 8411
=========================================
Files ? 1186
Lines ? 60800
Branches ? 6478
=========================================
Hits ? 27510
Misses ? 30305
Partials ? 2985
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `61.78% <53.84%> (ø)` | |
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4028756659
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.29%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 57.29% -0.02%
Complexity 18627 18627
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 61262 -9
- Misses 39854 39868 +14
- Partials 5791 5793 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.47% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <53.84%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-3.87%)` | :arrow_down: |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027651592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
}, {
"hash" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468",
"triggerID" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"triggerType" : "PUSH"
}, {
"hash" : "a55b2fd22ec98338f874a612df2024d85bcff6e6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12510",
"triggerID" : "a55b2fd22ec98338f874a612df2024d85bcff6e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a55b2fd22ec98338f874a612df2024d85bcff6e6 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12510)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "kbuci (via GitHub)" <gi...@apache.org>.
kbuci commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2875426912
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -102,15 +102,23 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean> buildClusteringGroupsForP
}
if (!currentGroup.isEmpty()) {
- if (currentGroup.size() > 1 || writeConfig.shouldClusteringSingleGroup()) {
- int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
- log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
- + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
- fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
- }
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
+ log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
+ + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
+ fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
}
- return Pair.of(fileSliceGroups.stream().map(fileSliceGroup ->
+ return Pair.of(fileSliceGroups.stream().filter(fileSliceGroup -> {
+ if (fileSliceGroup.getLeft().size() == 1 && fileSliceGroup.getRight() == 1 && !writeConfig.shouldClusteringSingleGroup()) {
+ FileSlice targetedFileSlice = fileSliceGroup.getLeft().get(0);
+ long size = targetedFileSlice.getBaseFile().isPresent() ? targetedFileSlice.getBaseFile().get().getFileSize() : writeConfig.getParquetMaxFileSize();
+ log.info(String.format("Removing clustering group due to input and output slices both being 1 and single group clustering is disabled."
+ + " Group stats: currentGroupSize= %s, maxBytesPerClusteringGroup= %s",
+ size, writeConfig.getClusteringMaxBytesInGroup()));
Review Comment:
I updated the if statement to remove the negation , to make it easier to follow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988048012
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.36%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1203b21) and HEAD (283283b). Click for more details.
>
> <details><summary>HEAD has 11 uploads less than BASE</summary>
>
>| Flag | BASE (1203b21) | HEAD (283283b) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.31% 43.36% -13.95%
+ Complexity 18602 13844 -4758
=============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
=============================================
- Hits 61085 46273 -14812
- Misses 39734 55094 +15360
+ Partials 5761 5330 -431
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.01% <53.84%> (-13.46%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <53.84%> (-12.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.16% <53.84%> (-25.53%)` | :arrow_down: |
... and [788 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988106165
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.24%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.31% 57.24% -0.07%
+ Complexity 18602 18600 -2
============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
============================================
- Hits 61085 61083 -2
- Misses 39734 39854 +120
+ Partials 5761 5760 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.41% <53.84%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `90.83% <53.84%> (-3.86%)` | :arrow_down: |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3888404035
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0823b4923202e68e8398143352001b8a880c645d Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988054152
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.42%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1203b21) and HEAD (283283b). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (1203b21) | HEAD (283283b) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.31% 43.42% -13.90%
+ Complexity 18602 13857 -4745
=============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
=============================================
- Hits 61085 46331 -14754
- Misses 39734 55048 +15314
+ Partials 5761 5318 -443
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.65% <53.84%> (-13.82%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <53.84%> (-12.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.16% <53.84%> (-25.53%)` | :arrow_down: |
... and [786 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988089279
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.31% 57.23% -0.08%
+ Complexity 18602 18598 -4
============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
============================================
- Hits 61085 61073 -12
- Misses 39734 39861 +127
- Partials 5761 5763 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.33% <53.84%> (-0.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `90.83% <53.84%> (-3.86%)` | :arrow_down: |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "kbuci (via GitHub)" <gi...@apache.org>.
kbuci commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2886626359
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -102,15 +102,23 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean> buildClusteringGroupsForP
}
if (!currentGroup.isEmpty()) {
- if (currentGroup.size() > 1 || writeConfig.shouldClusteringSingleGroup()) {
- int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
- log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
- + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
- fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
- }
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
+ log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
+ + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
+ fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
}
- return Pair.of(fileSliceGroups.stream().map(fileSliceGroup ->
+ return Pair.of(fileSliceGroups.stream().filter(fileSliceGroup -> {
+ if (fileSliceGroup.getLeft().size() > 1 || fileSliceGroup.getRight() > 1 || writeConfig.shouldClusteringSingleGroup()) {
Review Comment:
Oh here were as selecting which clustering groups to "allow". So in order for us to not remove a clustering group, one of the below conditions has to be true
- There are multiple input files in the group (stitching together small files)
- There are multiple output files in the group ("splitting" a large file)
- The user config specifies to allow clustering groups with a single file group (either explicitly via that config or implicitly by providing sort columns)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010686347
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.42%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.24% 55.42% -1.82%
+ Complexity 18617 17968 -649
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
- Hits 61152 59214 -1938
- Misses 39906 41774 +1868
- Partials 5765 5842 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.34% <53.84%> (-4.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.52% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [253 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008722940
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.40%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 45.25% 43.40% -1.85%
- Complexity 8412 13869 +5457
============================================
Files 1186 1954 +768
Lines 60793 106830 +46037
Branches 6478 13198 +6720
============================================
+ Hits 27512 46372 +18860
- Misses 30296 55126 +24830
- Partials 2985 5332 +2347
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.55% <53.84%> (?)` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (+6.12%)` | :arrow_up: |
... and [1151 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008714495
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.01%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 45.25% 40.01% -5.24%
- Complexity 8412 12448 +4036
============================================
Files 1186 1937 +751
Lines 60793 104414 +43621
Branches 6478 12599 +6121
============================================
+ Hits 27512 41784 +14272
- Misses 30296 57646 +27350
- Partials 2985 4984 +1999
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <53.84%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `68.29% <53.84%> (+4.49%)` | :arrow_up: |
... and [1032 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008774854
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.21%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
+ Coverage 55.49% 57.21% +1.72%
- Complexity 17993 18611 +618
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
+ Hits 59278 61124 +1846
+ Misses 41714 39940 -1774
+ Partials 5831 5766 -65
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.31% <53.84%> (+3.87%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-2.15%)` | :arrow_down: |
... and [236 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027796607
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.29%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 57.29% -0.02%
+ Complexity 18627 18626 -1
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 61260 -11
- Misses 39854 39868 +14
- Partials 5791 5795 +4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.40% <53.84%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <53.84%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-3.87%)` | :arrow_down: |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3881890657
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6380dc82e7b86451539c77ac044fd5b581d7555a Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3881816607
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6380dc82e7b86451539c77ac044fd5b581d7555a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988067686
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.77%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1203b21) and HEAD (283283b). Click for more details.
>
> <details><summary>HEAD has 8 uploads less than BASE</summary>
>
>| Flag | BASE (1203b21) | HEAD (283283b) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.31% 48.77% -8.55%
+ Complexity 18602 15805 -2797
============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
============================================
- Hits 61085 52039 -9046
- Misses 39734 49314 +9580
+ Partials 5761 5344 -417
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.13% <53.84%> (-4.34%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <53.84%> (-12.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `89.16% <53.84%> (-5.53%)` | :arrow_down: |
... and [537 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988070266
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.50%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.31% 55.50% -1.81%
+ Complexity 18602 17978 -624
============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
============================================
- Hits 61085 59223 -1862
- Misses 39734 41646 +1912
- Partials 5761 5828 +67
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.44% <53.84%> (-4.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `90.83% <53.84%> (-3.86%)` | :arrow_down: |
... and [233 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988068923
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.43%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.31% 55.43% -1.88%
+ Complexity 18602 17949 -653
============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
============================================
- Hits 61085 59150 -1935
- Misses 39734 41707 +1973
- Partials 5761 5840 +79
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.33% <53.84%> (-4.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `90.83% <53.84%> (-3.86%)` | :arrow_down: |
... and [251 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "kbuci (via GitHub)" <gi...@apache.org>.
kbuci commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2875123361
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -102,15 +102,23 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean> buildClusteringGroupsForP
}
if (!currentGroup.isEmpty()) {
- if (currentGroup.size() > 1 || writeConfig.shouldClusteringSingleGroup()) {
- int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
- log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
- + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
- fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
- }
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
+ log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
+ + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
+ fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
}
- return Pair.of(fileSliceGroups.stream().map(fileSliceGroup ->
+ return Pair.of(fileSliceGroups.stream().filter(fileSliceGroup -> {
+ if (fileSliceGroup.getLeft().size() == 1 && fileSliceGroup.getRight() == 1 && !writeConfig.shouldClusteringSingleGroup()) {
+ FileSlice targetedFileSlice = fileSliceGroup.getLeft().get(0);
+ long size = targetedFileSlice.getBaseFile().isPresent() ? targetedFileSlice.getBaseFile().get().getFileSize() : writeConfig.getParquetMaxFileSize();
+ log.info(String.format("Removing clustering group due to input and output slices both being 1 and single group clustering is disabled."
+ + " Group stats: currentGroupSize= %s, maxBytesPerClusteringGroup= %s",
+ size, writeConfig.getClusteringMaxBytesInGroup()));
Review Comment:
If there are sort columns then we shouldn't enter this if-statement , since we make sure that shouldClusteringSingleGroup is false. And that would return turn if there were sort columns
```
public boolean shouldClusteringSingleGroup() {
return isClusteringSortEnabled() || isSingleGroupClusteringEnabled();
}
public String getClusteringSortColumns() {
return getString(HoodieClusteringConfig.PLAN_STRATEGY_SORT_COLUMNS);
}
public boolean isClusteringSortEnabled() {
return !StringUtils.isNullOrEmpty(getString(HoodieClusteringConfig.PLAN_STRATEGY_SORT_COLUMNS));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3987611545
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9efbb40005d86e090aec4b61c8985c1bf0b3b89e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027690337
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.35%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 55.35% -1.96%
+ Complexity 18627 17933 -694
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 59188 -2083
- Misses 39854 41846 +1992
- Partials 5791 5889 +98
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.38% <53.84%> (-4.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <53.84%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [280 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027692325
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.43%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 55.43% -1.88%
+ Complexity 18627 17956 -671
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 59271 -2000
- Misses 39854 41779 +1925
- Partials 5791 5873 +82
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.38% <53.84%> (-4.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <53.84%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [258 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010765569
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.25%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=========================================
Coverage 57.24% 57.25%
- Complexity 18617 18623 +6
=========================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
=========================================
+ Hits 61152 61164 +12
+ Misses 39906 39904 -2
+ Partials 5765 5762 -3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.43% <53.84%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.52% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-3.87%)` | :arrow_down: |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010684513
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.42%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.24% 55.42% -1.82%
+ Complexity 18617 17968 -649
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
- Hits 61152 59214 -1938
- Misses 39906 41774 +1868
- Partials 5765 5842 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.34% <53.84%> (-4.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.52% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [253 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2791401562
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -102,15 +102,23 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean> buildClusteringGroupsForP
}
if (!currentGroup.isEmpty()) {
- if (currentGroup.size() > 1 || writeConfig.shouldClusteringSingleGroup()) {
- int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
- log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
- + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
- fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
- }
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
+ log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
+ + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
+ fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
}
- return Pair.of(fileSliceGroups.stream().map(fileSliceGroup ->
+ return Pair.of(fileSliceGroups.stream().filter(fileSliceGroup -> {
+ if (fileSliceGroup.getLeft().size() == 1 && fileSliceGroup.getRight() == 1 && !writeConfig.isSingleGroupClusteringEnabled()) {
+ FileSlice targetedFileSlice = fileSliceGroup.getLeft().get(0);
+ long size = targetedFileSlice.getBaseFile().isPresent() ? targetedFileSlice.getBaseFile().get().getFileSize() : writeConfig.getParquetMaxFileSize();
Review Comment:
This checks `isSingleGroupClusteringEnabled()` but the original code used `shouldClusteringSingleGroup()`, which also returns true when sort columns are configured (`isClusteringSortEnabled()`). With this change, if a user has sort columns set but `single.group.clustering.enabled=false`, we'd skip clustering a single file — but sorting a single file into a different layout is still a meaningful operation. Is this new behavior intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "kbuci (via GitHub)" <gi...@apache.org>.
kbuci commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2796474337
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -102,15 +102,23 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean> buildClusteringGroupsForP
}
if (!currentGroup.isEmpty()) {
- if (currentGroup.size() > 1 || writeConfig.shouldClusteringSingleGroup()) {
- int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
- log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
- + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
- fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
- }
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
+ log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
+ + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
+ fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
}
- return Pair.of(fileSliceGroups.stream().map(fileSliceGroup ->
+ return Pair.of(fileSliceGroups.stream().filter(fileSliceGroup -> {
+ if (fileSliceGroup.getLeft().size() == 1 && fileSliceGroup.getRight() == 1 && !writeConfig.isSingleGroupClusteringEnabled()) {
+ FileSlice targetedFileSlice = fileSliceGroup.getLeft().get(0);
+ long size = targetedFileSlice.getBaseFile().isPresent() ? targetedFileSlice.getBaseFile().get().getFileSize() : writeConfig.getParquetMaxFileSize();
Review Comment:
Sorry that was a typo, thanks for catching. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008189413
hey @kbuci : can you rebase w/ latest master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4009029868
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a66c47010fbdd72cf12845e954d1ba36d15810d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008395547
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 283283b39d2b040ba24f96db8053425892ce32b0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380)
* 5a66c47010fbdd72cf12845e954d1ba36d15810d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010393711
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
}, {
"hash" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5a66c47010fbdd72cf12845e954d1ba36d15810d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458)
* c5f7228c2411862f1c71c25014621813738b7d9a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010747587
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.24%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.24% 57.24% -0.01%
- Complexity 18617 18622 +5
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
+ Hits 61152 61155 +3
- Misses 39906 39911 +5
+ Partials 5765 5764 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.39% <53.84%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.52% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-3.87%)` | :arrow_down: |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027688046
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.18%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 55.18% -2.12%
+ Complexity 18627 17898 -729
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 59009 -2262
- Misses 39854 42041 +2187
- Partials 5791 5873 +82
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.18% <53.84%> (-4.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <53.84%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [296 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027639726
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.42%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (22aa1fa) and HEAD (a55b2fd). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (22aa1fa) | HEAD (a55b2fd) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.30% 43.42% -13.89%
+ Complexity 18627 13880 -4747
=============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
=============================================
- Hits 61271 46427 -14844
- Misses 39854 55166 +15312
+ Partials 5791 5330 -461
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <53.84%> (-14.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <53.84%> (-12.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (-26.64%)` | :arrow_down: |
... and [785 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027797436
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.29%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 57.29% -0.02%
Complexity 18627 18627
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 61262 -9
- Misses 39854 39868 +14
- Partials 5791 5793 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.47% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <53.84%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-3.87%)` | :arrow_down: |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3987876302
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9efbb40005d86e090aec4b61c8985c1bf0b3b89e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377)
* 283283b39d2b040ba24f96db8053425892ce32b0 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason merged PR #18172:
URL: https://github.com/apache/hudi/pull/18172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988055326
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.45%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1203b21) and HEAD (283283b). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (1203b21) | HEAD (283283b) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.31% 43.45% -13.86%
+ Complexity 18602 13867 -4735
=============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
=============================================
- Hits 61085 46368 -14717
- Misses 39734 55016 +15282
+ Partials 5761 5313 -448
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.19% <53.84%> (-14.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <53.84%> (-12.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.16% <53.84%> (-25.53%)` | :arrow_down: |
... and [786 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988043283
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.65%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1203b21) and HEAD (283283b). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (1203b21) | HEAD (283283b) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.31% 39.65% -17.67%
+ Complexity 18602 12607 -5995
=============================================
Files 1948 1948
Lines 106580 106697 +117
Branches 13174 13196 +22
=============================================
- Hits 61085 42308 -18777
- Misses 39734 59313 +19579
+ Partials 5761 5076 -685
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <53.84%> (-12.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `67.50% <53.84%> (-27.20%)` | :arrow_down: |
... and [858 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3987867957
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9efbb40005d86e090aec4b61c8985c1bf0b3b89e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377)
* 283283b39d2b040ba24f96db8053425892ce32b0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2886039523
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -102,15 +102,23 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean> buildClusteringGroupsForP
}
if (!currentGroup.isEmpty()) {
- if (currentGroup.size() > 1 || writeConfig.shouldClusteringSingleGroup()) {
- int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
- log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
- + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
- fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
- }
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
+ log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
+ + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
+ fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
}
- return Pair.of(fileSliceGroups.stream().map(fileSliceGroup ->
+ return Pair.of(fileSliceGroups.stream().filter(fileSliceGroup -> {
+ if (fileSliceGroup.getLeft().size() > 1 || fileSliceGroup.getRight() > 1 || writeConfig.shouldClusteringSingleGroup()) {
Review Comment:
shouldn't this be both == 1 ? essentially, instead of "OR", I am asking if it has to be "AND"?
for eg, what incase, someone wants to slice a larger file groups into smaller ones.
each partition contains 1 parquet file of 1GB. and user would want to make it 120Mb*10 ish files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2830375734
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -102,15 +102,23 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean> buildClusteringGroupsForP
}
if (!currentGroup.isEmpty()) {
- if (currentGroup.size() > 1 || writeConfig.shouldClusteringSingleGroup()) {
- int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
- log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
- + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
- fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
- }
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
+ log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
+ + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
+ fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
}
- return Pair.of(fileSliceGroups.stream().map(fileSliceGroup ->
+ return Pair.of(fileSliceGroups.stream().filter(fileSliceGroup -> {
+ if (fileSliceGroup.getLeft().size() == 1 && fileSliceGroup.getRight() == 1 && !writeConfig.shouldClusteringSingleGroup()) {
+ FileSlice targetedFileSlice = fileSliceGroup.getLeft().get(0);
+ long size = targetedFileSlice.getBaseFile().isPresent() ? targetedFileSlice.getBaseFile().get().getFileSize() : writeConfig.getParquetMaxFileSize();
+ log.info(String.format("Removing clustering group due to input and output slices both being 1 and single group clustering is disabled."
+ + " Group stats: currentGroupSize= %s, maxBytesPerClusteringGroup= %s",
+ size, writeConfig.getClusteringMaxBytesInGroup()));
Review Comment:
where are we checking for sort columns before returning `false` ?
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/clustering/plan/strategy/TestSparkSizeBasedClusteringPlanStrategy.java:
##########
@@ -82,11 +82,36 @@ public void testBuildClusteringGroup() {
Assertions.assertEquals(1, clusteringGroups.get(1).getNumOutputFileGroups());
}
+ @Test
+ public void testRemaningFileInPartitionNotClustered() {
+ HoodieWriteConfig config = HoodieWriteConfig.newBuilder()
+ .withPath("")
+ .withClusteringConfig(HoodieClusteringConfig.newBuilder()
+ .withClusteringPlanStrategyClass(SparkSizeBasedClusteringPlanStrategy.class.getName())
+ .withClusteringMaxBytesInGroup(2000)
+ .withClusteringTargetFileMaxBytes(1000)
+ .withClusteringPlanSmallFileLimit(500)
+ .withSingleGroupClusteringEnabled(false)
+ .build())
+ .build();
+
+ SparkSizeBasedClusteringPlanStrategy planStrategy = new SparkSizeBasedClusteringPlanStrategy(table, context, config);
+
+ ArrayList<FileSlice> fileSlices = new ArrayList<>();
+ fileSlices.add(createFileSlice(200));
+
+ Stream<HoodieClusteringGroup> clusteringGroupStream = (Stream<HoodieClusteringGroup>) planStrategy.buildClusteringGroupsForPartition("p0", fileSlices).getLeft();
+ List<HoodieClusteringGroup> clusteringGroups = clusteringGroupStream.collect(Collectors.toList());
+
+ // The only file in partition should not be clustered
+ Assertions.assertEquals(0, clusteringGroups.size());
Review Comment:
lets add a test where we set sort columns, and clustering plan should generate a plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027610303
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.98%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (22aa1fa) and HEAD (a55b2fd). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (22aa1fa) | HEAD (a55b2fd) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.30% 39.98% -17.32%
+ Complexity 18627 12447 -6180
=============================================
Files 1955 1938 -17
Lines 106916 104507 -2409
Branches 13225 12626 -599
=============================================
- Hits 61271 41792 -19479
- Misses 39854 57719 +17865
+ Partials 5791 4996 -795
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.31% <53.84%> (-12.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `68.29% <53.84%> (-28.26%)` | :arrow_down: |
... and [877 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008386161
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 283283b39d2b040ba24f96db8053425892ce32b0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380)
* 5a66c47010fbdd72cf12845e954d1ba36d15810d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010727942
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.24%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.24% 57.24% -0.01%
- Complexity 18617 18619 +2
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
+ Hits 61152 61154 +2
- Misses 39906 39911 +5
Partials 5765 5765
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.35% <53.84%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.52% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-3.87%)` | :arrow_down: |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010815167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
}, {
"hash" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12377",
"triggerID" : "9efbb40005d86e090aec4b61c8985c1bf0b3b89e",
"triggerType" : "PUSH"
}, {
"hash" : "283283b39d2b040ba24f96db8053425892ce32b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12380",
"triggerID" : "283283b39d2b040ba24f96db8053425892ce32b0",
"triggerType" : "PUSH"
}, {
"hash" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12458",
"triggerID" : "5a66c47010fbdd72cf12845e954d1ba36d15810d",
"triggerType" : "PUSH"
}, {
"hash" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468",
"triggerID" : "c5f7228c2411862f1c71c25014621813738b7d9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5f7228c2411862f1c71c25014621813738b7d9a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12468)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008779621
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.23%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
+ Coverage 55.49% 57.23% +1.74%
- Complexity 17993 18618 +625
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
+ Hits 59278 61149 +1871
+ Misses 41714 39914 -1800
+ Partials 5831 5767 -64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.41% <53.84%> (+3.97%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-2.15%)` | :arrow_down: |
... and [236 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "kbuci (via GitHub)" <gi...@apache.org>.
kbuci commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2875123361
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/strategy/PartitionAwareClusteringPlanStrategy.java:
##########
@@ -102,15 +102,23 @@ protected Pair<Stream<HoodieClusteringGroup>, Boolean> buildClusteringGroupsForP
}
if (!currentGroup.isEmpty()) {
- if (currentGroup.size() > 1 || writeConfig.shouldClusteringSingleGroup()) {
- int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
- log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
- + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
- fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
- }
+ int numOutputGroups = getNumberOfOutputFileGroups(totalSizeSoFar, writeConfig.getClusteringTargetFileMaxBytes());
+ log.info("Adding final clustering group " + totalSizeSoFar + " max bytes: "
+ + writeConfig.getClusteringMaxBytesInGroup() + " num input slices: " + currentGroup.size() + " output groups: " + numOutputGroups);
+ fileSliceGroups.add(Pair.of(currentGroup, numOutputGroups));
}
- return Pair.of(fileSliceGroups.stream().map(fileSliceGroup ->
+ return Pair.of(fileSliceGroups.stream().filter(fileSliceGroup -> {
+ if (fileSliceGroup.getLeft().size() == 1 && fileSliceGroup.getRight() == 1 && !writeConfig.shouldClusteringSingleGroup()) {
+ FileSlice targetedFileSlice = fileSliceGroup.getLeft().get(0);
+ long size = targetedFileSlice.getBaseFile().isPresent() ? targetedFileSlice.getBaseFile().get().getFileSize() : writeConfig.getParquetMaxFileSize();
+ log.info(String.format("Removing clustering group due to input and output slices both being 1 and single group clustering is disabled."
+ + " Group stats: currentGroupSize= %s, maxBytesPerClusteringGroup= %s",
+ size, writeConfig.getClusteringMaxBytesInGroup()));
Review Comment:
If there are sort columns then we shouldn't enter this if-statement , since we make sure that shouldClusteringSingleGroup is false. And that would have returned true if there were sort columns
```
public boolean shouldClusteringSingleGroup() {
return isClusteringSortEnabled() || isSingleGroupClusteringEnabled();
}
public String getClusteringSortColumns() {
return getString(HoodieClusteringConfig.PLAN_STRATEGY_SORT_COLUMNS);
}
public boolean isClusteringSortEnabled() {
return !StringUtils.isNullOrEmpty(getString(HoodieClusteringConfig.PLAN_STRATEGY_SORT_COLUMNS));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "kbuci (via GitHub)" <gi...@apache.org>.
kbuci commented on code in PR #18172:
URL: https://github.com/apache/hudi/pull/18172#discussion_r2875140640
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/clustering/plan/strategy/TestSparkSizeBasedClusteringPlanStrategy.java:
##########
@@ -82,11 +82,36 @@ public void testBuildClusteringGroup() {
Assertions.assertEquals(1, clusteringGroups.get(1).getNumOutputFileGroups());
}
+ @Test
+ public void testRemaningFileInPartitionNotClustered() {
+ HoodieWriteConfig config = HoodieWriteConfig.newBuilder()
+ .withPath("")
+ .withClusteringConfig(HoodieClusteringConfig.newBuilder()
+ .withClusteringPlanStrategyClass(SparkSizeBasedClusteringPlanStrategy.class.getName())
+ .withClusteringMaxBytesInGroup(2000)
+ .withClusteringTargetFileMaxBytes(1000)
+ .withClusteringPlanSmallFileLimit(500)
+ .withSingleGroupClusteringEnabled(false)
+ .build())
+ .build();
+
+ SparkSizeBasedClusteringPlanStrategy planStrategy = new SparkSizeBasedClusteringPlanStrategy(table, context, config);
+
+ ArrayList<FileSlice> fileSlices = new ArrayList<>();
+ fileSlices.add(createFileSlice(200));
+
+ Stream<HoodieClusteringGroup> clusteringGroupStream = (Stream<HoodieClusteringGroup>) planStrategy.buildClusteringGroupsForPartition("p0", fileSlices).getLeft();
+ List<HoodieClusteringGroup> clusteringGroups = clusteringGroupStream.collect(Collectors.toList());
+
+ // The only file in partition should not be clustered
+ Assertions.assertEquals(0, clusteringGroups.size());
Review Comment:
Added test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3987842187
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.24%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9efbb40`](https://app.codecov.io/gh/apache/hudi/commit/9efbb40005d86e090aec4b61c8985c1bf0b3b89e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1203b21) and HEAD (9efbb40). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (1203b21) | HEAD (9efbb40) |
>|------|------|------|
>|spark-scala-tests|6|0|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.31% 45.24% -12.07%
+ Complexity 18602 8394 -10208
=============================================
Files 1948 1180 -768
Lines 106580 60668 -45912
Branches 13174 6476 -6698
=============================================
- Hits 61085 27452 -33633
+ Misses 39734 30233 -9501
+ Partials 5761 2983 -2778
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `60.83% <53.84%> (-33.86%)` | :arrow_down: |
... and [1384 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4027797760
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.29%. Comparing base ([`22aa1fa`](https://app.codecov.io/gh/apache/hudi/commit/22aa1fad6a0bc96e3a3e9479584e87ae3e2a8509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a55b2fd`](https://app.codecov.io/gh/apache/hudi/commit/a55b2fd22ec98338f874a612df2024d85bcff6e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.30% 57.29% -0.02%
Complexity 18627 18627
============================================
Files 1955 1955
Lines 106916 106923 +7
Branches 13225 13225
============================================
- Hits 61271 61262 -9
- Misses 39854 39868 +14
- Partials 5791 5793 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.47% <53.84%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.57% <53.84%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `92.68% <53.84%> (-3.87%)` | :arrow_down: |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3888338021
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922",
"triggerID" : "6380dc82e7b86451539c77ac044fd5b581d7555a",
"triggerType" : "PUSH"
}, {
"hash" : "0823b4923202e68e8398143352001b8a880c645d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969",
"triggerID" : "0823b4923202e68e8398143352001b8a880c645d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6380dc82e7b86451539c77ac044fd5b581d7555a Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11922)
* 0823b4923202e68e8398143352001b8a880c645d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11969)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988042059
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.01%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1203b21) and HEAD (283283b). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (1203b21) | HEAD (283283b) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.31% 40.01% -17.30%
+ Complexity 18602 12435 -6167
=============================================
Files 1948 1931 -17
Lines 106580 104281 -2299
Branches 13174 12597 -577
=============================================
- Hits 61085 41729 -19356
- Misses 39734 57575 +17841
+ Partials 5761 4977 -784
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.32% <53.84%> (-12.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `67.50% <53.84%> (-27.20%)` | :arrow_down: |
... and [876 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-3988033668
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.25%. Comparing base ([`1203b21`](https://app.codecov.io/gh/apache/hudi/commit/1203b215b03cb5c76fffb46a360efe0c4ce21fe0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`283283b`](https://app.codecov.io/gh/apache/hudi/commit/283283b39d2b040ba24f96db8053425892ce32b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (1203b21) and HEAD (283283b). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (1203b21) | HEAD (283283b) |
>|------|------|------|
>|spark-scala-tests|6|0|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.31% 45.25% -12.06%
+ Complexity 18602 8398 -10204
=============================================
Files 1948 1180 -768
Lines 106580 60668 -45912
Branches 13174 6476 -6698
=============================================
- Hits 61085 27457 -33628
+ Misses 39734 30231 -9503
+ Partials 5761 2980 -2781
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <53.84%> (-0.09%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `60.83% <53.84%> (-33.86%)` | :arrow_down: |
... and [1384 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010704481
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.49%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 57.24% 55.49% -1.75%
+ Complexity 18617 17997 -620
============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
============================================
- Hits 61152 59287 -1865
- Misses 39906 41713 +1807
- Partials 5765 5830 +65
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.45% <53.84%> (-3.97%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.52% <53.84%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (-5.50%)` | :arrow_down: |
... and [235 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008723447
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.44%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
============================================
- Coverage 45.25% 43.44% -1.81%
- Complexity 8412 13880 +5468
============================================
Files 1186 1954 +768
Lines 60793 106830 +46037
Branches 6478 13198 +6720
============================================
+ Hits 27512 46416 +18904
- Misses 30296 55094 +24798
- Partials 2985 5320 +2335
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.19% <53.84%> (?)` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (+6.12%)` | :arrow_up: |
... and [1151 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4008740622
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.46%. Comparing base ([`4499b0b`](https://app.codecov.io/gh/apache/hudi/commit/4499b0b2bd43bd90f4dd22e9631d401dae4c19da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a66c47`](https://app.codecov.io/gh/apache/hudi/commit/5a66c47010fbdd72cf12845e954d1ba36d15810d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
+ Coverage 43.45% 55.46% +12.01%
- Complexity 13878 17986 +4108
=============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
=============================================
+ Hits 46416 59252 +12836
+ Misses 55088 41745 -13343
- Partials 5319 5833 +514
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <53.84%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.40% <53.84%> (+10.20%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.51% <53.84%> (+12.38%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `91.05% <53.84%> (+18.64%)` | :arrow_up: |
... and [690 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010617500
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.40%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (6e0d786) and HEAD (c5f7228). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (6e0d786) | HEAD (c5f7228) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.24% 43.40% -13.84%
+ Complexity 18617 13870 -4747
=============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
=============================================
- Hits 61152 46372 -14780
- Misses 39906 55126 +15220
+ Partials 5765 5332 -433
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.56% <53.84%> (-13.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (-12.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `69.91% <53.84%> (-26.64%)` | :arrow_down: |
... and [786 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(table-services): When single clustering group config is disabled, clustering should not create clustering groups with same number of input/output files [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18172:
URL: https://github.com/apache/hudi/pull/18172#issuecomment-4010593456
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.84615%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.65%. Comparing base ([`6e0d786`](https://app.codecov.io/gh/apache/hudi/commit/6e0d786b52b84190d12e8cea5b048d97ce59421d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c5f7228`](https://app.codecov.io/gh/apache/hudi/commit/c5f7228c2411862f1c71c25014621813738b7d9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | 53.84% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (6e0d786) and HEAD (c5f7228). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (6e0d786) | HEAD (c5f7228) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18172 +/- ##
=============================================
- Coverage 57.24% 39.65% -17.60%
+ Complexity 18617 12620 -5997
=============================================
Files 1954 1954
Lines 106823 106830 +7
Branches 13198 13198
=============================================
- Hits 61152 42360 -18792
- Misses 39906 59387 +19481
+ Partials 5765 5083 -682
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.20% <53.84%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <53.84%> (-12.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18172?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...strategy/PartitionAwareClusteringPlanStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/18172?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FPartitionAwareClusteringPlanStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L1BhcnRpdGlvbkF3YXJlQ2x1c3RlcmluZ1BsYW5TdHJhdGVneS5qYXZh) | `68.29% <53.84%> (-28.26%)` | :arrow_down: |
... and [859 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18172/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org