You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/26 12:41:21 UTC

[GitHub] [airflow] ecerulm opened a new pull request #12640: Improve breeze help messages

ecerulm opened a new pull request #12640:
URL: https://github.com/apache/airflow/pull/12640


   * **initialize-local-virtualenv**: on the event of failure it recomends to change `LDFLAGS` and `CPPFLAGS`  to that it pick up the ssl library from the location where `brew` installs it.
   * **static-check --help**: now includes an example on how to run the checks for all files changed by your current branch.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ecerulm commented on a change in pull request #12640: Improve breeze help messages

Posted by GitBox <gi...@apache.org>.
ecerulm commented on a change in pull request #12640:
URL: https://github.com/apache/airflow/pull/12640#discussion_r531030990



##########
File path: breeze
##########
@@ -1862,6 +1864,7 @@ ${FORMATTED_STATIC_CHECKS}
       '${CMDNAME} static-check mypy' or
       '${CMDNAME} static-check mypy -- --files tests/core.py'
       '${CMDNAME} static-check mypy -- --all-files'
+      '${CMDNAME} static-check all -- --from-ref `git merge-base master HEAD` --to-ref HEAD # checks all files that differ from master'

Review comment:
       I changed it to `\$(git merge-base... )` and move the comment at the end as new line. 
       




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #12640: Improve breeze help messages

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12640:
URL: https://github.com/apache/airflow/pull/12640#issuecomment-734311300


   Thanks!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #12640: Improve breeze help messages

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12640:
URL: https://github.com/apache/airflow/pull/12640#issuecomment-734281763


   The PR is ready to be merged. No tests are needed!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #12640: Improve breeze help messages

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12640:
URL: https://github.com/apache/airflow/pull/12640#discussion_r531009436



##########
File path: breeze
##########
@@ -1862,6 +1864,7 @@ ${FORMATTED_STATIC_CHECKS}
       '${CMDNAME} static-check mypy' or
       '${CMDNAME} static-check mypy -- --files tests/core.py'
       '${CMDNAME} static-check mypy -- --all-files'
+      '${CMDNAME} static-check all -- --from-ref `git merge-base master HEAD` --to-ref HEAD # checks all files that differ from master'

Review comment:
       The  ` wil have to be escaped - otherwise, it will try to run the git commnd.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #12640: Improve breeze help messages

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12640:
URL: https://github.com/apache/airflow/pull/12640


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org