You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/27 05:50:59 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1738: Polish SnapshotService
TeslaCN opened a new pull request #1738:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1738
Changes proposed in this pull request:
- Validate port in constructor and replace RuntimeExeption with IllegalArgumentException.
- Modify "Elastic job" to "ElasticJob".
- Set thread name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1738: Polish SnapshotService
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1738:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1738#issuecomment-734659970
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=h1) Report
> Merging [#1738](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=desc) (54a9150) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/81d5b8016ed270b04767dc9d0ee67b78abc99a02?el=desc) (81d5b80) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
============================================
- Coverage 86.20% 86.20% -0.01%
+ Complexity 105 104 -1
============================================
Files 252 252
Lines 5683 5682 -1
Branches 878 878
============================================
- Hits 4899 4898 -1
Misses 470 470
Partials 314 314
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `82.53% <66.66%> (-0.28%)` | `0.00 <0.00> (-1.00)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=footer). Last update [81d5b80...54a9150](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1738: Polish SnapshotService
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1738:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1738#issuecomment-734662034
Windows CI failed for network reason.
```
Error: Failed to execute goal on project elasticjob-restful: Could not resolve dependencies for project org.apache.shardingsphere.elasticjob:elasticjob-restful:jar:3.0.0-RC1-SNAPSHOT: Failed to collect dependencies at io.netty:netty-codec-http:jar:4.1.45.Final: Failed to read artifact descriptor for io.netty:netty-codec-http:jar:4.1.45.Final: Could not transfer artifact io.netty:netty-codec-http:pom:4.1.45.Final from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/io/netty/netty-codec-http/4.1.45.Final/netty-codec-http-4.1.45.Final.pom: Connection reset -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1738: Polish SnapshotService
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1738:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1738#issuecomment-734659970
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=h1) Report
> Merging [#1738](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=desc) (54a9150) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/81d5b8016ed270b04767dc9d0ee67b78abc99a02?el=desc) (81d5b80) will **decrease** coverage by `0.00%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
============================================
- Coverage 86.20% 86.20% -0.01%
+ Complexity 105 104 -1
============================================
Files 252 252
Lines 5683 5682 -1
Branches 878 878
============================================
- Hits 4899 4898 -1
Misses 470 470
Partials 314 314
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `82.53% <66.66%> (-0.28%)` | `0.00 <0.00> (-1.00)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=footer). Last update [81d5b80...54a9150](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1738: Polish SnapshotService
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1738:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org