[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40357: [SPARK-42739][BUILD] Ensure release tag to be pushed to release branch

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #40357:
URL: https://github.com/apache/spark/pull/40357#discussion_r1131893994


##########
dev/create-release/release-tag.sh:
##########
@@ -122,6 +122,12 @@ if ! is_dry_run; then
   git push origin $RELEASE_TAG
   if [[ $RELEASE_VERSION != *"preview"* ]]; then
     git push origin HEAD:$GIT_BRANCH

Review Comment:
   Hm, so to clarify, we set `set -e` on the top, meaning that the script will fail immediately if any command fails with non-zero exit.
   
   I assume that there's a case when `git push origin $RELEASE_TAG` and `git push origin HEAD:$GIT_BRANCH` are successfully executed but the tag still doesn't exist? If that's the case LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org