[GitHub] [kafka] C0urante commented on a diff in pull request #13912: MINOR: Silence error logs for faulty plugins in integration tests

["C0urante (via GitHub)" <gi...@apache.org>]

C0urante commented on code in PR #13912:
URL: https://github.com/apache/kafka/pull/13912#discussion_r1240123793


##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##########
@@ -554,7 +554,7 @@ private ConsumerRecords<byte[], byte[]> records(ConsumerRecord<byte[], byte[]> r
     private abstract static class TestSinkTask extends SinkTask {
     }
 
-    static class FaultyConverter extends JsonConverter {
+    public static class FaultyConverter extends JsonConverter {

Review Comment:
   Worth adding a comment on why these are public, so that a future contributor doesn't accidentally revert this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org