You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 10:00:29 UTC

[GitHub] [flink] cshuo opened a new pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

cshuo opened a new pull request #12119:
URL: https://github.com/apache/flink/pull/12119


   …produce NPE in some cases existing aggregate call with Filter.
   
   ## What is the purpose of the change
   
   When generating code for Filter predicate of aggregate call in `HashAggCodeGenHelper`, we should check the nullability of the boolean field firstly rather than `getBoolean` directly, otherwise, NPE may be produced.
   
   ## Brief change log
   * This PR fix bugs in `HashAggCodeGenHelper`.
   
   ## Verifying this change
   This change added tests:
   * Add integration test in `AggregateITCaseBase` for end-to-end test.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302",
       "triggerID" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6492295182327f4a8289816abd20d6a8e66e35b1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6492295182327f4a8289816abd20d6a8e66e35b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302) 
   * 6492295182327f4a8289816abd20d6a8e66e35b1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] cshuo commented on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
cshuo commented on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628482729


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302",
       "triggerID" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 13962fa6930cf29f65ab11a368660f95ff4f29bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197) 
   * 6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284) 
   * f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 13962fa6930cf29f65ab11a368660f95ff4f29bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 13962fa6930cf29f65ab11a368660f95ff4f29bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197) 
   * 6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302",
       "triggerID" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284) 
   * f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-627883041


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6492295182327f4a8289816abd20d6a8e66e35b1 (Fri Oct 16 10:34:50 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] cshuo closed pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
cshuo closed pull request #12119:
URL: https://github.com/apache/flink/pull/12119


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 13962fa6930cf29f65ab11a368660f95ff4f29bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197) 
   * 6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284) 
   * f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302",
       "triggerID" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302",
       "triggerID" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6492295182327f4a8289816abd20d6a8e66e35b1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1362",
       "triggerID" : "6492295182327f4a8289816abd20d6a8e66e35b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6492295182327f4a8289816abd20d6a8e66e35b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1362) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingsongLi merged pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12119:
URL: https://github.com/apache/flink/pull/12119


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 13962fa6930cf29f65ab11a368660f95ff4f29bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197) 
   * 6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628150518


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1197",
       "triggerID" : "13962fa6930cf29f65ab11a368660f95ff4f29bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1284",
       "triggerID" : "6deeafe89af1ad6cedcbfbb12b8d5a53407aa3f0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302",
       "triggerID" : "f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6492295182327f4a8289816abd20d6a8e66e35b1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1362",
       "triggerID" : "6492295182327f4a8289816abd20d6a8e66e35b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f2ab38fb3fd70e6fa9f9de2350dfb9b6bb4a477c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1302) 
   * 6492295182327f4a8289816abd20d6a8e66e35b1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1362) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingsongLi commented on pull request #12119: [FLINK-17649][table-planner-blink] Generated hash aggregate code may …

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12119:
URL: https://github.com/apache/flink/pull/12119#issuecomment-628446486


   ```
   2020-05-13T20:07:26.0126805Z [ERROR] Crashed tests:
   2020-05-13T20:07:26.0127192Z [ERROR] org.apache.flink.table.planner.runtime.batch.sql.DecimalITCase
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org