You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/18 08:22:42 UTC
[GitHub] [flink] alpreu opened a new pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
alpreu opened a new pull request #19146:
URL: https://github.com/apache/flink/pull/19146
## What is the purpose of the change
Because users depend on the `ActionFailureHandler` we need to revert the Table API implementation of the Elasticsearch Sink back to the SinkFunction one. This is only transitory but necessary for 1.15
## Brief change log
- Reverted changes to TableAPI modules back to SinkFunction based one
- Backported FLINK-24571 (`now()`function in dynamic indexes)
- Updated connector docs for Table API
## Verifying this change
This change added tests and can be verified as follows:
- Added the tests from the old SinkFunction-based module
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54bedab85bcb7da3ae70fd6002e629b3c1c5767a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #19146:
URL: https://github.com/apache/flink/pull/19146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311",
"triggerID" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54bedab85bcb7da3ae70fd6002e629b3c1c5767a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54bedab85bcb7da3ae70fd6002e629b3c1c5767a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311",
"triggerID" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"triggerType" : "PUSH"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361",
"triggerID" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"triggerType" : "PUSH"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1073768825",
"triggerType" : "MANUAL"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1073768825",
"triggerType" : "MANUAL"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361",
"triggerID" : "1073776663",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* e948e2ec1f2e6403b63a97033572c14af39a922b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361)
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311",
"triggerID" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"triggerType" : "PUSH"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361",
"triggerID" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"triggerType" : "PUSH"
}, {
"hash" : "0000",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1073768825",
"triggerType" : "MANUAL"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361",
"triggerID" : "1073776663",
"triggerType" : "MANUAL"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361",
"triggerID" : "1073768825",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* e948e2ec1f2e6403b63a97033572c14af39a922b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361)
* 0000 Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311",
"triggerID" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"triggerType" : "PUSH"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54bedab85bcb7da3ae70fd6002e629b3c1c5767a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311)
* e948e2ec1f2e6403b63a97033572c14af39a922b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311",
"triggerID" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"triggerType" : "PUSH"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361",
"triggerID" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 54bedab85bcb7da3ae70fd6002e629b3c1c5767a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311)
* e948e2ec1f2e6403b63a97033572c14af39a922b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1073768825
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1073776663
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19146: [FLINK-26638][connnectors/elasticsearch] Revert Table API implementation to SinkFunction
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19146:
URL: https://github.com/apache/flink/pull/19146#issuecomment-1072163587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33311",
"triggerID" : "54bedab85bcb7da3ae70fd6002e629b3c1c5767a",
"triggerType" : "PUSH"
}, {
"hash" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361",
"triggerID" : "e948e2ec1f2e6403b63a97033572c14af39a922b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e948e2ec1f2e6403b63a97033572c14af39a922b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33361)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org