You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Reijhanniel Jearl Campos <no...@github.com> on 2015/11/11 13:28:37 UTC

[jclouds-labs] JCLOUDS-947: Properly configure live tests in ProfitBricks (#222)

*WIP*. Creating PR for early comments. Ran live test with:

```sh
➜  profitbricks git:(develop) mvn clean install -Plive -Dtest.profitbricks.identity=<username> -Dtest.profitbricks.credential=<password> -Dtest.profitbricks.template=<image_id>
```
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/222

-- Commit Summary --

  * JCLOUDS-947: (WIP) Properly configure live tests in ProfitBricks

-- File Changes --

    M profitbricks/src/main/java/org/jclouds/profitbricks/binder/loadbalancer/DeregisterLoadBalancerRequestBinder.java (4)
    M profitbricks/src/main/java/org/jclouds/profitbricks/binder/loadbalancer/RegisterLoadBalancerRequestBinder.java (6)
    M profitbricks/src/main/java/org/jclouds/profitbricks/compute/config/ProfitBricksComputeServiceContextModule.java (93)
    D profitbricks/src/main/java/org/jclouds/profitbricks/compute/internal/ProvisioningStatusPollingPredicate.java (70)
    M profitbricks/src/main/java/org/jclouds/profitbricks/config/ProfitBricksComputeProperties.java (1)
    M profitbricks/src/main/java/org/jclouds/profitbricks/domain/Location.java (5)
    M profitbricks/src/main/java/org/jclouds/profitbricks/features/IpBlockApi.java (5)
    M profitbricks/src/main/java/org/jclouds/profitbricks/features/LoadBalancerApi.java (15)
    M profitbricks/src/main/java/org/jclouds/profitbricks/features/NicApi.java (16)
    A profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/loadbalancer/LoadBalancerIdOnlyResponseHandler.java (51)
    A profitbricks/src/main/java/org/jclouds/profitbricks/http/parser/nic/NicIdOnlyResponseHandler.java (51)
    M profitbricks/src/test/java/org/jclouds/profitbricks/BaseProfitBricksLiveTest.java (161)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/DeregisterLoadBalancerRequestBinderTest.java (17)
    M profitbricks/src/test/java/org/jclouds/profitbricks/binder/loadbalancer/RegisterLoadBalancerRequestBinderTest.java (18)
    R profitbricks/src/test/java/org/jclouds/profitbricks/compute/config/StatusPredicateTest.java (62)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/DataCenterApiLiveTest.java (16)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/DrivesApiLiveTest.java (64)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/FirewallApiLiveTest.java (110)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/ImageApiLiveTest.java (30)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/IpBlockApiLiveTest.java (63)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/IpBlockApiMockTest.java (4)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/LoadBalancerApiLiveTest.java (127)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/LoadBalancerApiMockTest.java (31)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/NicApiLiveTest.java (104)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/NicApiMockTest.java (27)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/ServerApiLiveTest.java (71)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/SnapshotApiLiveTest.java (133)
    M profitbricks/src/test/java/org/jclouds/profitbricks/features/StorageApiLiveTest.java (65)
    A profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/loadbalancer/LoadBalancerIdOnlyResponseHandlerTest.java (41)
    R profitbricks/src/test/java/org/jclouds/profitbricks/http/parser/nic/NicIdOnlyResponseHandlerTest.java (29)
    M profitbricks/src/test/resources/loadbalancer/loadbalancer-create.xml (28)
    M profitbricks/src/test/resources/loadbalancer/loadbalancer-deregister.xml (26)
    M profitbricks/src/test/resources/loadbalancer/loadbalancer-register.xml (32)
    M profitbricks/src/test/resources/loadbalancer/loadbalancer-update.xml (27)
    A profitbricks/src/test/resources/logback-test.xml (74)
    M profitbricks/src/test/resources/nic/nic-delete.xml (21)
    M profitbricks/src/test/resources/nic/nic-internetaccess.xml (23)
    M profitbricks/src/test/resources/nic/nic-update.xml (27)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/222.patch
https://github.com/jclouds/jclouds-labs/pull/222.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/222

Re: [jclouds-labs] JCLOUDS-947: Properly configure live tests in ProfitBricks (#222)

Posted by Ignasi Barrera <no...@github.com>.
Pushed to master as [42afafd0](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/42afafd0). Many thanks @devcsrj!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/222#issuecomment-157875043

Re: [jclouds-labs] JCLOUDS-947: Properly configure live tests in ProfitBricks (#222)

Posted by Reijhanniel Jearl Campos <no...@github.com>.
> the objective of this PR isn't to fix all tests, but to allow us to run all them at once
:+1 That make sense! In that case, objective-wise, this PR is done. 

I'll squash this PR so that you can cleanly merge it. :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/222#issuecomment-156597295

Re: [jclouds-labs] JCLOUDS-947: Properly configure live tests in ProfitBricks (#222)

Posted by Ignasi Barrera <no...@github.com>.
Closed #222.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/222#event-468500423

Re: [jclouds-labs] JCLOUDS-947: Properly configure live tests in ProfitBricks (#222)

Posted by Ignasi Barrera <no...@github.com>.
Awesome work here @devcsrj! I like the proposed changes in the tests, and also the code cleanup in the compute predicates. Both are changes in the right direction. Thanks!
I see that the tests that are failing are mostly the ComputeService ones.

I'd propose to go step by step and merge the PR once it is ready (the objective of this PR isn't to fix all tests, but to allow us to run all them at once), and fix the failing tests in other PRs. WDYT?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/222#issuecomment-156250751