You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/11/30 19:50:25 UTC

[kudu-CR] KUDU-721 Support for Decimal type: Part 1 (C++)

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5104

to look at the new patch set (#5).

Change subject: KUDU-721 Support for Decimal type: Part 1 (C++)
......................................................................

KUDU-721 Support for Decimal type: Part 1 (C++)

This patch introduces a Decimal type to Kudu. It's based on
column attributes, which are bits of information attached to a
ColumnSchema. For a Decimal column, the attributes are the
precision and scale of the Decimal column. Decimal attributes
determine

1. The server-side storage/physical type of the column, either
INT32 or INT64. This should be invisible to clients.
2. How clients should interpret the values of a decimal column.

No other types use attributes at this time.

The design of the Decimal column is based on Impala's decimal type.
The maximum precision is 18, the largest precision whose maximum
value can be stored in a 64-bit integer.

This patch contains only server-side and C++ client Decimal support.
Java support will follow.

Change-Id: I4f7829cdad883f5c124a437327062b2b45b6841b
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-unittest.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/value.cc
M src/kudu/client/value.h
M src/kudu/common/CMakeLists.txt
M src/kudu/common/common.proto
A src/kudu/common/decimal_value-test.cc
A src/kudu/common/decimal_value.cc
A src/kudu/common/decimal_value.h
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/common/wire_protocol.cc
M src/kudu/consensus/log-test.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/server/webui_util.cc
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/multi_column_writer.cc
M src/kudu/tablet/tablet-decoder-eval-test.cc
30 files changed, 1,174 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5104/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f7829cdad883f5c124a437327062b2b45b6841b
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>