You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2017/10/16 13:37:10 UTC
[isis] 04/08: ISIS-1742: deletes commented out code in
BackgroundCommandExecution
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch dev/2.0.0/ISIS-1742-remove-deprecations
in repository https://gitbox.apache.org/repos/asf/isis.git
commit 1c51dff958c56e3a982b238569a55e007a77767e
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Mon Oct 16 14:28:10 2017 +0100
ISIS-1742: deletes commented out code in BackgroundCommandExecution
---
.../background/BackgroundCommandExecution.java | 55 ----------------------
1 file changed, 55 deletions(-)
diff --git a/core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java b/core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
index 2b9303d..7ab5003 100644
--- a/core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
+++ b/core/runtime/src/main/java/org/apache/isis/core/runtime/services/background/BackgroundCommandExecution.java
@@ -125,37 +125,6 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
final boolean legacy = false; // memento.startsWith("<memento");
if(legacy) {
-// final ActionInvocationMemento aim = new ActionInvocationMemento(mementoService, memento);
-//
-// final String actionId = aim.getActionId();
-//
-// final Bookmark targetBookmark = aim.getTarget();
-// final Object targetObject = bookmarkService.lookup(
-// targetBookmark, BookmarkService2.FieldResetPolicy.RESET);
-//
-// final ObjectAdapter targetAdapter = adapterFor(targetObject);
-// final ObjectSpecification specification = targetAdapter.getSpecification();
-//
-// final ObjectAction objectAction = findActionElseNull(specification, actionId);
-// if(objectAction == null) {
-// throw new RuntimeException(String.format("Unknown action '%s'", actionId));
-// }
-//
-// // TODO: background commands won't work for mixin actions...
-// // ... we obtain the target from the bookmark service (above), which will
-// // simply fail for a mixin. Instead we would need to serialize out the mixedInAdapter
-// // and also capture the mixinType within the aim memento.
-// final ObjectAdapter mixedInAdapter = null;
-//
-// final ObjectAdapter[] argAdapters = argAdaptersFor(aim);
-// final ObjectAdapter resultAdapter = objectAction.execute(
-// targetAdapter, mixedInAdapter, argAdapters, InteractionInitiatedBy.FRAMEWORK);
-//
-// if(resultAdapter != null) {
-// Bookmark resultBookmark = CommandUtil.bookmarkFor(resultAdapter);
-// backgroundCommand.setResult(resultBookmark);
-// backgroundInteraction.getCurrentExecution().setReturned(resultAdapter.getObject());
-// }
} else {
@@ -305,30 +274,6 @@ public abstract class BackgroundCommandExecution extends AbstractIsisSessionTemp
return null;
}
-// private ObjectAdapter[] argAdaptersFor(final ActionInvocationMemento aim) {
-// final int numArgs = aim.getNumArgs();
-// final List<ObjectAdapter> argumentAdapters = Lists.newArrayList();
-// for(int i=0; i<numArgs; i++) {
-// final ObjectAdapter argAdapter = argAdapterFor(aim, i);
-// argumentAdapters.add(argAdapter);
-// }
-// return argumentAdapters.toArray(new ObjectAdapter[]{});
-// }
-//
-// private ObjectAdapter argAdapterFor(final ActionInvocationMemento aim, int num) {
-// final Class<?> argType;
-// try {
-// argType = aim.getArgType(num);
-// final Object arg = aim.getArg(num, argType);
-// if(arg == null) {
-// return null;
-// }
-// return argAdapterFor(argType, arg);
-//
-// } catch (ClassNotFoundException e) {
-// throw new RuntimeException(e);
-// }
-// }
protected ObjectAdapter targetAdapterFor(final OidDto targetOidDto) {
--
To stop receiving notification emails like this one, please contact
"commits@isis.apache.org" <co...@isis.apache.org>.