You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/20 11:25:04 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #3166:
[CodeStyle] Rename new_partition_aggregation_node and
new_partitioned_hash_table
HappenLee opened a new pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table
URL: https://github.com/apache/incubator-doris/pull/3166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request
#3166: [CodeStyle] Rename new_partition_aggregation_node and
new_partitioned_hash_table
Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table
URL: https://github.com/apache/incubator-doris/pull/3166#discussion_r395577456
##########
File path: be/src/exec/partitioned_hash_table.h
##########
@@ -42,7 +42,7 @@ class RowDescriptor;
class RuntimeState;
class Tuple;
class TupleRow;
-class NewPartitionedHashTable;
+class PartitionedHashTable;
Review comment:
class PartitionedHashTable place before class RowDescriptor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli merged pull request #3166: [CodeStyle]
Rename new_partition_aggregation_node and new_partitioned_hash_table
Posted by GitBox <gi...@apache.org>.
chaoyli merged pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table
URL: https://github.com/apache/incubator-doris/pull/3166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request
#3166: [CodeStyle] Rename new_partition_aggregation_node and
new_partitioned_hash_table
Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #3166: [CodeStyle] Rename new_partition_aggregation_node and new_partitioned_hash_table
URL: https://github.com/apache/incubator-doris/pull/3166#discussion_r395576703
##########
File path: be/src/exec/partitioned_aggregation_node_ir.cc
##########
@@ -15,9 +15,9 @@
// specific language governing permissions and limitations
// under the License.
-#include "exec/new_partitioned_aggregation_node.h"
+#include "exec/partitioned_aggregation_node.h"
-#include "exec/new_partitioned_hash_table.inline.h"
+#include "exec/partitioned_hash_table.inline.h"
Review comment:
#include "exec/partitioned_hash_table.inline.h" after #include "exprs/new_agg_fn_evaluator.h"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org