You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/22 10:53:45 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #11732: Ensure that manually creating a DAG run doesn't "block" the scheduler

kaxil commented on a change in pull request #11732:
URL: https://github.com/apache/airflow/pull/11732#discussion_r510066955



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1640,11 +1652,13 @@ def _schedule_dag_run(self, dag_run: DagRun, currently_active_runs: int, session
             return 0
 
         if dag.max_active_runs:
-            if currently_active_runs >= dag.max_active_runs:
+            if len(currently_active_runs) >= dag.max_active_runs and \
+               dag_run.execution_date not in currently_active_runs:
                 self.log.info(

Review comment:
       not needed for this PR but should we change this to DEBUG as I remember it was a bit spammy




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org