Re: [PR] Simplify DruidCoordinatorConfig and binding of metadata cleanup duties (druid)

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis commented on code in PR #14891:
URL: https://github.com/apache/druid/pull/14891#discussion_r1322395091


##########
services/src/main/java/org/apache/druid/cli/CliCoordinator.java:
##########
@@ -248,14 +240,7 @@ public void configure(Binder binder)
             LifecycleModule.register(binder, Server.class);
             LifecycleModule.register(binder, DataSourcesResource.class);
 
-            // Binding for Set of indexing service coordinator Duty
-            final ConditionalMultibind<CoordinatorDuty> conditionalIndexingServiceDutyMultibind = ConditionalMultibind.create(
-                properties,
-                binder,
-                CoordinatorDuty.class,
-                CoordinatorIndexingServiceDuty.class
-            );

Review Comment:
   does this mean extensions can no longer provide custom coordinator duties? If so this might require a dev list thread to see if anyone is using this functionality.
   
   It does make sense to update the built-in ones to be handled in a more direct manner, but I wonder if there is some way we could leave this stuff in place to retain this functionality as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org